1129133 - Clean up GeckoTouchDispatcher so that it's a real singleton

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Mason Chang [Inactive] [:mchang]]

Right now the GeckoTouchDispatcher is a quasi-singleton. Clean it up a little so that it's a real one.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Part 1: Cleanup GeckoTouchDispatcher so that it's a singleton

Cleans up the GeckoTouchDispatcher so that it is a singleton and remove the static methods and make them non-static.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Part 2: Add a reference to the GeckoTouchDispatcher in the CompositorVsyncObserver

Adds a reference to the GeckoTouchDispatcher from the CompositorVsyncObserver. Waiting on try to make sure ClearOnShutdown, which executes on the main thread, is actually the last reference and not the CompositorVsyncObserver.

Comment 3

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8559527 [details] [diff] [review]
Part 2: Add a reference to the GeckoTouchDispatcher in the CompositorVsyncObserver

Verified that ClearOnShutdown executes the last reference and the GeckoTouchDispatcher is cleaned up on the main thread.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8559527 [details] [diff] [review]
Part 2: Add a reference to the GeckoTouchDispatcher in the CompositorVsyncObserver

Review of attachment 8559527 [details] [diff] [review]:
-----------------------------------------------------------------

Do you need to keep a ref locally? I'd rather if you just called GeckoTouchDispatcher::GetInstance()->whatever where you need it. I worry about cyclical references and doing this would avoid that problem.

Comment 5

[Mason Chang [Inactive] [:mchang]]

Attachment: Part 2: Use GeckoTouchDispatcher singleton instead of static methods

From comment 4, updated to use GetInstance() instead of holding a reference.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8560178 [details] [diff] [review]
Part 2: Use GeckoTouchDispatcher singleton instead of static methods

Review of attachment 8560178 [details] [diff] [review]:
-----------------------------------------------------------------

Please squash both parts into one patch when landing as neither will compile by itself.

Comment 7

[Mason Chang [Inactive] [:mchang]]

Attachment: Cleanup GeckoTouchDispatcher so that it's a singleton

Carrying r+, squashed into 1 from comment 6.

https://hg.mozilla.org/integration/b2g-inbound/rev/74794349faa8

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74794349faa8