Closed Bug 1129244 Opened 6 years ago Closed 6 years ago

[Nuwa] wrap pthread_mutex_trylock

Categories

(Core :: mozglue, defect)

Product:
Core
Component:
mozglue
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

patch
3.54 KB, patch
sinker
: review+
Details | Diff | Splinter Review 
pthread_mutex_lock is wrapped, I see no reason pthread_mutex_trylock shouldn't be too. In fact, it seems dangerous that it isn't.
Attached patch patch — — Splinter Review
Attachment #8558860 - Flags: review?(tlee)
No longer blocks: 1121269
Comment on attachment 8558860 [details] [diff] [review]
patch

Review of attachment 8558860 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

By definition, http://linux.die.net/man/3/pthread_mutex_lock , pthread_mutex_trylock() has the same behavior as pthread_mutex_lock(), except pthread_mutex_trylock() could be EBUSY, but pthread_mutex_lock() does not, and pthread_mutex_lock() could be EDEADLK, but pthread_mutex_trylock() does not.  They are so similar, so to wrap pthread_mutex_trylock() with the same pattern of code seems very promise.
Attachment #8558860 - Flags: review?(tlee) → review+
https://hg.mozilla.org/mozilla-central/rev/f478222a6166
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.