1129253 - Additional changed prefs to report to Telemetry/FHR

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Vladan Djeric (:vladan)]

There are additional prefs that impact performance that we should report.. Let's gather them in this bug and land them all at once?

1. whether Sync is enabled, not sure which of the services.sync.* prefs this is
2. whether the browser is set to restore sessions automatically
3. "Use smooth scrolling" in Advanced?
4. ...

Comment 1

[Georg Fritzsche [:gfritzsche]]

Should we just report them or should they go to the environment and trigger a session split?

Comment 3

[Benjamin Smedberg]

AIUI, sync being enabled is the default and there isn't a pref to disable. What I think we really care about is whether the user has an active sync account, which I think is already measured somewhere in the session ping but isn't something that feels like it should be in the environment.

Restore session automatically I believe is already covered by the browser.startup.* prefs.

Smooth scrolling is fine to add.

Comment 4

[Vladan Djeric (:vladan)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> AIUI, sync being enabled is the default and there isn't a pref to disable.
> What I think we really care about is whether the user has an active sync
> account, 

Right

> which I think is already measured somewhere in the session ping but
> isn't something that feels like it should be in the environment.

We've seen sync cause jank in the past, so I just want it reported, I don't feel strongly that it should cause an environment split

> Restore session automatically I believe is already covered by the
> browser.startup.* prefs.

oh you're right, it's browser.startup.page

Comment 5

[Georg Fritzsche [:gfritzsche]]

Added "general.smoothScroll" on bug 1131138.

(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #4)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> > AIUI, sync being enabled is the default and there isn't a pref to disable.
> > What I think we really care about is whether the user has an active sync
> > account, 
> 
> Right
> 
> > which I think is already measured somewhere in the session ping but
> > isn't something that feels like it should be in the environment.
> 
> We've seen sync cause jank in the past, so I just want it reported, I don't
> feel strongly that it should cause an environment split

This should be covered by bug 1121010.

Comment 6

[Georg Fritzsche [:gfritzsche]]

Closing in favor of bug 1131138.