[mozdevice] Gecko and Gaia revisions aren't cached between suites

RESOLVED FIXED

Status

Firefox OS
Gaia::PerformanceTest
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Eli, Assigned: Eli)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
When I was working on the initial implementation of mozdevice, I was storing Gecko and Gaia revisions statically so that they would cache in-between test suites. In my eventual refactoring though I moved the revisions to be instance properties and this lost the caching side effect. In mozdevice/index.js we should store a reference to the revisions and return the cache upon future instantiations.
(Assignee)

Comment 1

3 years ago
Created attachment 8559312 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/4
Attachment #8559312 - Flags: review?(rwood)

Comment 2

3 years ago
Comment on attachment 8559312 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/4

LGTM and works fine, ran the launch test on flame, single and multiple iterations with single and multiple apps.
Attachment #8559312 - Flags: review?(rwood) → review+
(Assignee)

Comment 3

3 years ago
Merged, published to mozdevice@1.2.1.
(Assignee)

Updated

3 years ago
Attachment #8559425 - Attachment description: [PullReq] eliperelman:bug-1129273 to mozilla-b2g:master → Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/4
Attachment #8559425 - Flags: review?(kgrandon)
(Assignee)

Updated

3 years ago
Attachment #8559425 - Attachment description: Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/4 → Link to Github pull-request: https://github.com/mozilla-b2g/gaia-node-modules/pull/90
Comment on attachment 8559425 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia-node-modules/pull/90

R+ on this and the gaia_node_modules.revision bump if necessary.
Attachment #8559425 - Flags: review?(kgrandon) → review+
Created attachment 8559860 [details] [review]
[PullReq] eliperelman:bug-1129273 to mozilla-b2g:master
(Assignee)

Comment 7

3 years ago
Comment on attachment 8559860 [details] [review]
[PullReq] eliperelman:bug-1129273 to mozilla-b2g:master

Carrying over r+ from kgrandon.
Attachment #8559860 - Flags: review+
(Assignee)

Comment 8

3 years ago
Try run: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=c38b449ba720
In master: https://github.com/mozilla-b2g/gaia/commit/51f3321de45accd4fcedc0d8a6a46d0fef0eba34
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.