1129321 - Remove nonstandard let blocks from browser

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: browser.patch

let blocks are a nonstandard SpiderMonkey feature we would like to remove (in bug 1023609). This patch removes the let blocks in the browser/ subtree.

The attached patch excludes whitespace changes because most of the patch is unindenting blocks of unchanged code from the removed let blocks. This made the important bits of the patch harder to review.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8558981 [details] [diff] [review]
browser.patch

Review of attachment 8558981 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the indentation of all the blocks fixed that now aren't blocks anymore. That basically affects all of the files :)

::: browser/components/places/tests/browser/head.js
@@ +21,2 @@
>      if (cachedLeftPaneFolderIdGetter && typeof(getter) != "function")
> +    PlacesUIUtils.__defineGetter__("leftPaneFolderId", cachedLeftPaneFolderIdGetter);

That indentation doesn't look right. Can you please add curly braces while you're at it?

Comment 2

[Chris Peterson [:cpeterson]]

Thanks. I fixed the indentation and added curly braces.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e37cf0a00e0f

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e37cf0a00e0f