Closed Bug 1129330 Opened 9 years ago Closed 9 years ago

Remove nonstandard let blocks from mobile

Categories

(Firefox for Android Graveyard :: Testing, defect)

Product:
Firefox for Android Graveyard
Component:
Testing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

mobile.patch
3.58 KB, patch
nalexander
: review+
Details | Diff | Splinter Review
Attached patch mobile.patch — — Splinter Review 
let blocks are a nonstandard SpiderMonkey feature we would like to remove (in bug 1023609). This patch removes the let blocks in the mobile/ subtree.

The attached patch excludes whitespace changes because most of the patch is unindenting blocks of unchanged code from the removed let blocks. This made the important bits of the patch harder to review.
Attachment #8558989 - Flags: review?(nalexander)
Attachment #8558989 - Attachment is patch: true
Attachment #8558989 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 8558989 [details] [diff] [review]
mobile.patch

Review of attachment 8558989 [details] [diff] [review]:
-----------------------------------------------------------------

Roll on.  This was all cargo-culted from testing/xpcshell/head.js; do whatever is appropriate.
Attachment #8558989 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/9813bea61397
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Blocks: 1167029
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: