Closed
Bug 1129339
Opened 9 years ago
Closed 9 years ago
[Flame][Dialer]The text in context menu button disappears.
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-b2g:2.2+, b2g-v2.1 unaffected, b2g-v2.2 verified, b2g-master verified)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | unaffected |
b2g-v2.2 | --- | verified |
b2g-master | --- | verified |
People
(Reporter: lulu.tian, Assigned: drs)
References
Details
(Keywords: regression, Whiteboard: [planned-sprint c=1])
Attachments
(8 files)
149.97 KB,
text/plain
|
Details | |
1.16 MB,
video/mp4
|
Details | |
23.32 KB,
image/png
|
Details | |
23.99 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
drs
:
review+
|
Details | Review |
4.43 KB,
patch
|
thills
:
review+
bajaj
:
approval-gaia-v2.2+
jlorenzo
:
qa-approval+
|
Details | Diff | Splinter Review |
1.26 MB,
video/mp4
|
Details | |
947.28 KB,
video/mp4
|
Details |
[1.Description]: [Flame v2.2][Dialer]When you long press on a call log, the context menu pops up without text in buttons. Found time:06:24 See attachment:logcat_0624.txt and video.MP4 [2.Testing Steps]: Prerequisite: Have at least one call log. 1. Launch Phone app. 2. Navigate to Call log screen. 3. Long press at a call log. [3.Expected Result]: 3. The context menu should pop up with text in. [4.Actual Result]: 3. The context menu is shown as blank. [5.Reproduction build]: Flame 2.2 build: Build ID 20150203002504 Gaia Revision cd62ff9fe199fb43920ba27bd5fdbc5c311016fc Gaia Date 2015-02-03 00:56:43 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/11d93135c678 Gecko Version 37.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150203.041704 Firmware Date Tue Feb 3 04:17:15 EST 2015 Bootloader L1TC000118D0 Flame 2.1 build: Build ID 20150203001532 Gaia Revision 17bf14f12e43043654498330d610d469b8b55e64 Gaia Date 2015-02-03 05:19:41 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/014f57033b8a Gecko Version 34.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150203.041012 Firmware Date Tue Feb 3 04:10:23 EST 2015 Bootloader L1TC000118D0 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test
Comment 2•9 years ago
|
||
Video shows two bugs. 1. The record shows "911" instead of "Emerengcy number" ( The correct behavior ->> Call_Log.png ) 2. The text on the buttons disappeared. Definitely, it is a regression. ( The correct behavior ->> Alternative_ menu.png )
Comment 3•9 years ago
|
||
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
(In reply to William Hsu [:whsu] from comment #2) > Video shows two bugs. > 1. The record shows "911" instead of "Emerengcy number" > ( The correct behavior ->> Call_Log.png ) > 2. The text on the buttons disappeared. Definitely, it is a regression. > ( The correct behavior ->> Alternative_ menu.png ) Hi, Sue, May I have your help? Regarding the first problem, please help file a new bug. Many thanks.
Flags: needinfo?(lulu.tian)
Keywords: regression,
regressionwindow-wanted
Comment 6•9 years ago
|
||
This issue will only start to occur when looking at context menu for the number '911'. And after issue occurs, it affects all subsequent attempts on all numbers in the call log, even with regular numbers that didn't have that issue before attempting to view 911's context menu. Working on getting the window now.
status-b2g-master:
--- → affected
QA Contact: pcheng
Comment 7•9 years ago
|
||
b2g-inbound regression window: Last Working Environmental Variables: Device: Flame BuildID: 20150126135000 Gaia: b02ec9713e6de8d96c6954d2c0dfd0442b0656ac Gecko: 38e4719e71af Version: 38.0a1 (3.0 Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 First Broken Environmental Variables: Device: Flame BuildID: 20150126141259 Gaia: ef8b81a65a80fbfa019c5d70dd5916594837ebf7 Gecko: 3086135dda95 Version: 38.0a1 (3.0 Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Last Working Gaia & First Broken Gecko - issue does NOT repro Gaia: b02ec9713e6de8d96c6954d2c0dfd0442b0656ac Gecko: 3086135dda95 Last Working Gecko & First Broken Gaia - issue DOES repro Gaia: ef8b81a65a80fbfa019c5d70dd5916594837ebf7 Gecko: 38e4719e71af Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/b02ec9713e6de8d96c6954d2c0dfd0442b0656ac...ef8b81a65a80fbfa019c5d70dd5916594837ebf7 Caused by the patch for Bug 1102340.
Comment 8•9 years ago
|
||
Ahmed, can you take a look at this please? Looks like the landing for bug 1102340 might have caused this issue to occur.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(nefzaoui)
Hi William, I had opened a new Bug of the first problem you had mentioned in comment 2. See Bug 1129765
Flags: needinfo?(lulu.tian)
Comment 10•9 years ago
|
||
Thanks Pi Wei and Sue! :D
Comment 11•9 years ago
|
||
[Blocking Requested - why for this release]: Regression which prevents a user from using the Call Log info feature.
blocking-b2g: --- → 2.2?
Comment 12•9 years ago
|
||
Triage meeting: blocking as is a regression and the user experience is totally broken.
blocking-b2g: 2.2? → 2.2+
Assignee | ||
Updated•9 years ago
|
Whiteboard: [planned-sprint c=?]
Target Milestone: --- → 2.2 S6 (20feb)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → drs.bugzilla
Whiteboard: [planned-sprint c=?] → [planned-sprint c=1]
Comment 13•9 years ago
|
||
This might be caused by this line: https://github.com/mozilla-b2g/gaia/blob/2911e4f7b4e0748227482883fc049ae1cbc9e7b1/apps/communications/dialer/js/call_log.js#L495
Comment 17•9 years ago
|
||
Assignee | ||
Comment 18•9 years ago
|
||
PR: attachment 8561585 [details] [review] Johan, could you verify this?
Flags: needinfo?(nefzaoui) → needinfo?(jlorenzo)
Attachment #8561586 -
Flags: review?(thills)
Comment 19•9 years ago
|
||
Comment on attachment 8561586 [details] [diff] [review] Fix call log phone number bdi element creation and updates. With the patch applied: * The issue in comment 0 is no more * Bug 1129765 too. * Bug 1129839 also. I tested with one and then 2 logs to delete. In the meantime, I came across bug 1131261 (not related to this patch though), bug 1131278, a side effect of bug 1102814.
Flags: needinfo?(jlorenzo)
Attachment #8561586 -
Flags: qa-approval+
Comment 20•9 years ago
|
||
Comment on attachment 8561586 [details] [diff] [review] Fix call log phone number bdi element creation and updates. Hi Doug, Looks good to me. I ran across a few issues with updates when I tested, but I am sure these are related to bug 976990 and not related to this patch/issue. Thanks, -tamara
Attachment #8561586 -
Flags: review?(thills) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Attachment #8561585 -
Flags: review+
Updated•9 years ago
|
Keywords: checkin-needed
Comment 21•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/89f772868d51b0db04941355df174f2e8b45e75d
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 22•9 years ago
|
||
Needinfo myself to request uplift once all the duplicates are verified.
Flags: needinfo?(drs.bugzilla)
Reporter | ||
Comment 23•9 years ago
|
||
This issue has been verified successfully on Flame 3.0 STR: Prerequisite: Have at least one call log. 1. Launch Phone app. 2. Navigate to Call log screen. 3. Long press at a call log. **The context menu pops up with text in. See attachment:verify_v3.0.MP4 Rate:0/5 Flame 3.0 build: Build ID 20150214010227 Gaia Revision f0b93e0668ef9565bd6f050b15b4f794d59feb65 Gaia Date 2015-02-13 13:13:27 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/a7c177546ca0 Gecko Version 38.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150214.043959 Firmware Date Sat Feb 14 04:40:10 EST 2015 Bootloader L1TC000118D0
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
Assignee | ||
Comment 24•9 years ago
|
||
Comment on attachment 8561586 [details] [diff] [review] Fix call log phone number bdi element creation and updates. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 1102340 [User impact] if declined: Context menu for call log emergency calls will be broken. [Testing completed]: Verified. [Risk to taking this patch] (and alternatives if risky): Low. [String changes made]: None.
Flags: needinfo?(drs.bugzilla)
Attachment #8561586 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
Attachment #8561586 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 25•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/406f844f24685a4e970396b724bb67da13924ba2
Reporter | ||
Comment 26•9 years ago
|
||
This issue has been verified successfully on Flame 2.2 STR: Prerequisite: Have at least one call log. 1. Launch Phone app. 2. Navigate to Call log screen. 3. Long press at a call log. **The context menu pops up with text in. See attachment:verify_v2.2.MP4 Rate:0/5 Flame 2.2 build: Build ID 20150225002505 Gaia Revision ca64f2fe145909f31af266b1730874051ba76c78 Gaia Date 2015-02-24 22:06:53 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150225.041814 Firmware Date Wed Feb 25 04:18:25 EST 2015 Bootloader L1TC000118D0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•