IonMonkey MIPS: Reintroduce the lock in the simulator

RESOLVED FIXED in Firefox 38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla38
Other
All
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In bug 1128452 the lock on the icache and redirections fields on the Simulator object was reintroduced for the ARM simulator, since those fields can be accessed concurrently from an executor thread and from a background compiler thread.  The lock was mistakenly removed by earlier refactoring.

The lock similarly needs to be reintroduced in the MIPS simulator.
(Assignee)

Comment 1

4 years ago
Created attachment 8559034 [details] [diff] [review]
Critical section around shared variables in MIPS simulator

This is a straight port from the ARM code in bug 1128452 with the addition of a guard added to Simulator::FlushICache, where it was missing.  However that function is not called.  (Nor is the one in the ARM simulator called.)

(The MIPS simulator already has a bunch of jit-test errors; this patch just attempts to undo the damage of my earlier change.)
Attachment #8559034 - Flags: review?(jdemooij)
Attachment #8559034 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/1ed646daac4f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.