1129365 - getUserMedia Video/Camera broken due to preview/picture size mismatch

Status: VERIFIED FIXED

Description

[Cristina Madaras, QA [:CristinaM]]

Build: Firefox for Android 38.0a1 (2015-02-03)
Device: Samsung Galaxy S4 (Android 4.4.2)

Steps to reproduce:
1. Go to http://mozilla.github.com/webrtc-landing/gum_test.html;
2. Choose one option Video/ Audio/ Audio&Video;
3. Choose 'Share' option from the doorhanger.

Expected results: A video appears showing the content from the camera and an audio stream from the built-in microphone is heard. Visible indicators are present indicating that the camera and mic are active.

Actual results: The content of the device camera and the audio is not shown. 

Regression:
Last good: 29b05d283b00
First bad: d7e156a7a0a6
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=29b05d283b00&tochange=d7e156a7a0a6

Bug 1109248 caused this?

Comment 1

[Aaron Train [:aaronmt]]

getUserMedia works for me on my SII, Nexus 5 & Nexus 6, trunk Nightly 02/04. No

Comment 2

[Aaron Train [:aaronmt]]

Comment #1

(In reply to Aaron Train [:aaronmt] from comment #1)
> No problems here.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Logcat please?

Comment 4

[Cristina Madaras, QA [:CristinaM]]

Created attachment 8559184 [details]
logs.txt

I attached the logs.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Thanks. Relevant part:

02-04 17:55:04.040: D/WEBRTC-JC(20946): Camera orientation: 0 .Device orientation: 270
02-04 17:55:04.050: D/WEBRTC-JC(20946): isVideoStabilizationSupported: false
02-04 17:55:04.050: D/WEBRTC-JC(20946): Camera preview mfps range: 1000 - 30000
02-04 17:55:04.050: W/ServiceManager(292): Permission failure: com.sonyericsson.permission.CAMERA_EXTENDED from uid=10204 pid=20946
02-04 17:55:04.050: W/ServiceManager(292): Permission failure: com.sonyericsson.permission.CAMERA_EXTENDED from uid=10204 pid=20946
02-04 17:55:04.050: E/cald(292): 1921720197 excal_cam_ctrl.cpp                (3085) 21690 E [EXC] [COMP] [CamCtrl         056] Not support snapshot primary ImageSize(720 x 480)
02-04 17:55:04.060: E/WEBRTC-JC(20946): startCapture failed
02-04 17:55:04.060: E/WEBRTC-JC(20946): java.lang.RuntimeException: setParameters failed
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at android.hardware.Camera.native_setParameters(Native Method)
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at android.hardware.Camera.setParameters(Camera.java:1707)
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at org.webrtc.videoengine.VideoCaptureAndroid.access$100(VideoCaptureAndroid.java:48)
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at org.webrtc.videoengine.VideoCaptureAndroid$1.run(VideoCaptureAndroid.java:188)
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at android.os.Handler.handleCallback(Handler.java:733)
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at android.os.Handler.dispatchMessage(Handler.java:95)
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at android.os.Looper.loop(Looper.java:212)
02-04 17:55:04.060: E/WEBRTC-JC(20946):         at org.webrtc.videoengine.VideoCaptureAndroid$CameraThread.run(VideoCaptureAndroid.java:162)

Comment 6

[Gian-Carlo Pascutto [:gcp]]

The relevant change from the webrtc 40 update is this:

-      parameters.setPreviewSize(width, height)

+      parameters.setPictureSize(width, height);
+      parameters.setPreviewSize(width, height);

The setPictureSize is excepting. I need to look a bit why upstream made this change though. I'm a bit worried we're trying to start the camera at a resolution it didn't even report as being supported.

Comment 7

[Flaviu Cos]

Also reproducible on Samsung Galaxy R (Android 2.3.4);

Error thrown in logs:

startCapture failed
java.lang.RuntimeException: No preview surface for Camera.
at org.webrtc.videoengine.VideoCaptureAndroid.access$100(VideoCaptureAndroid.java:48)
at org.webrtc.videoengine.VideoCaptureAndroid$1.run(VideoCaptureAndroid.java:188)
at android.os.Handler.handleCallback(Handler.java:587)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:130)
at org.webrtc.videoengine.VideoCaptureAndroid$CameraThread.run(VideoCaptureAndroid.java:162)

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Hmm, I find no evidence we're doing it wrong. I couldn't reproduce the original issue on my Galaxy S3, but I tried to force things:

I/WebRTC  (26084):   Capture Device Index 0, Name Camera 0, Facing back, Orientation 90
I/WebRTC  (26084): Number of Capabilities 5
I/WebRTC  (26084): type=12 width=960 height=720 maxFPS=30
I/WebRTC  (26084): type=12 width=1280 height=720 maxFPS=30
I/WebRTC  (26084): type=12 width=640 height=480 maxFPS=30
I/WebRTC  (26084): type=12 width=352 height=288 maxFPS=30         <===========
I/WebRTC  (26084): type=12 width=320 height=240 maxFPS=30
I/WebRTC  (26084):   Capture Device Index 1, Name Camera 1, Facing front, Orientation 270
I/WebRTC  (26084): Number of Capabilities 7
I/WebRTC  (26084): type=12 width=960 height=720 maxFPS=30
I/WebRTC  (26084): type=12 width=1280 height=720 maxFPS=30
I/WebRTC  (26084): type=12 width=704 height=704 maxFPS=30         <= wtf
I/WebRTC  (26084): type=12 width=352 height=288 maxFPS=30         <===========
I/WebRTC  (26084): type=12 width=640 height=480 maxFPS=30
I/WebRTC  (26084): type=12 width=320 height=320 maxFPS=30
I/WebRTC  (26084): type=12 width=320 height=240 maxFPS=30

I then changed the default width/height to 500x300 which doesn't match anything.

D/WEBRTC-JC(26084): startCapture: 352x288@30000:30000        <= closest match so constraints doing their job
D/WEBRTC-JC(26084): Camera orientation: 90. Device orientation: 0
D/SecCameraCoreManager( 1940): getParameters
D/WEBRTC-JC(26084): isVideoStabilizationSupported: true
D/WEBRTC-JC(26084): Camera preview mfps range: 30000 - 30000
D/SecCameraCoreManager( 1940): setParameters
V/ShotSingle( 1940): setParameters(0)
D/ISecCameraHardware( 1940): setPreviewSize: preview 352x288
W/ISecCameraHardware( 1940): setPictureSize: warning, not supported size(352x288)  <= wut??
D/ISecCameraHardware( 1940): setPictureSize: 640x480
V/ISecCameraHardware( 1940): setFrameRate: 30000,30000
V/ISecCameraHardware( 1940): setFrameRate val: 30000
E/ISecCameraHardware( 1940): android::status_t android::ISecCameraHardware::checkArea(ssize_t, ssize_t, ssize_t, ssize_t, ssize_t, int): All values are zero
V/ISecCameraHardware( 1940): setVideoStabilization: true
V/ISecCameraHardware( 1940): setAntiBanding=50hz
E/ISecCameraHardware( 1940): FocusMode=continuous-video, PrevFocusMode=auto
V/ISecCameraHardware( 1940): setFocusMode: continuous-video
V/ISecCameraHardware( 1940): mFocusMode: 11
V/ISecCameraHardware( 1940): setCityid : null value
D/ISecCameraHardware( 1940): setParameters X: success

So the problem is that there's a mismatch between the probed capabilities and what the camera supports in setPictureSize. Checking the upstream code, the bug is there: the camera capabilities are queried with getSupportedPreviewSizes but then the code tries to do a setPictureSize with a value that's not necessarily supported.

Comment 9

[Gian-Carlo Pascutto [:gcp]]

(In reply to Flaviu Cos, QA [:flaviu] from comment #7)
> Also reproducible on Samsung Galaxy R (Android 2.3.4);
> 
> Error thrown in logs:
> 
> startCapture failed
> java.lang.RuntimeException: No preview surface for Camera.

Please file a new bug, this is a different problem.

Comment 10

[Gian-Carlo Pascutto [:gcp]]

Upstream bug:
https://code.google.com/p/webrtc/issues/detail?id=4197

Comment 11

[Flaviu Cos]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #9)
> 
> Please file a new bug, this is a different problem.

I filed Bug 1129858 for that issue.

Comment 12

[Gian-Carlo Pascutto [:gcp]]

Can you test this build and see if it fixes the issue?
https://dl.dropboxusercontent.com/u/32496746/fennec-camera-fix.apk

Comment 13

[Gian-Carlo Pascutto [:gcp]]

Created attachment 8559756 [details] [diff] [review]
Don't assume setPictureSize supports the same sizes as setPreviewSize

This should preserve the workaround for the Nexus 7 while
not causing issues on the other devices.

Comment 14

[Cristina Madaras, QA [:CristinaM]]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #12)
> Can you test this build and see if it fixes the issue?
> https://dl.dropboxusercontent.com/u/32496746/fennec-camera-fix.apk

I am not able to reproduce the issue on this build. All options Video/Audio/Audio&Video works as expected. Tested with Samsung Galaxy S4 (Android 4.4.2).

Comment 15

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d28d627b6a2

Comment 16

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/2d28d627b6a2

Comment 17

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 38.0a1 (2015-02-06);
Device: Samsung Galaxy S4 (Android 4.4.2).