Closed Bug 1129394 Opened 9 years ago Closed 9 years ago

"mach build-backend" should either auto-run configure or present a more useful error message when it hasn't been run

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: ted, Assigned: froydnj)

Details

Attachments

(1 file)

If you run "mach build-backend <whatever>" but haven't run "mach configure" you get an unhelpful error message. It should either auto-run configure for you if possible, or if not at least present a useful error message instructing you to run configure.

A contributor showed up in #build and presented a pastebin with this situation:
http://pastebin.com/uQqDbWA0
Something like this?  I guess we could run a |mach configure|-alike from here,
but this is at least an improvement on the status quo.
Attachment #8559117 - Flags: review?(ted)
Comment on attachment 8559117 [details] [diff] [review]
produce a useful error message for |mach build-backend| without having run configure

Review of attachment 8559117 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this is definitely better than what we have. Thanks!

::: python/mozbuild/mozbuild/mach_commands.py
@@ +587,5 @@
>          config_status = os.path.join(self.topobjdir, 'config.status')
>  
> +        if not os.path.exists(config_status):
> +            print('config.status not found.  Please run %s or |mach build| '
> +                  'prior to building the %s build backend.'

I would probably suggest 'mach configure' instead of the path to the configure script.
Attachment #8559117 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/f4570d1ff1df
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Assignee: nobody → nfroyd
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: