1129453 - Display new answers from other people when viewing a question

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Anthony Ricaud (:rik)]

We currently don't receive the new answers. We're thinking of receiving them from a different SimplePush notification.

Comment 1

[Kadir Topal [:atopal]]

Can you expand on this? Does this mean messages between two people work, but others joining won't have their message displayed? Or something else?

Comment 2

[Anthony Ricaud (:rik)]

This is about the "liveness" of the chat. When you are viewing a question, you don't see new messages sent by people in real time.

Comment 3

[Anthony Ricaud (:rik)]

The server will forgot about the client 10 minutes after a simplepush notification has been set. So if we get a 404 when checking the last questions, we should just refresh the view.

Comment 4

[Anthony Ricaud (:rik)]

Notes on the API format:

POST /api/2/realtime/
{
endpoint: https://updates.mozil…
content_type: 'question',
object_id: question_id
}
-> { id }

DELETE /api/2/realtime/{id}/

GET /api/2/realtime/{id}/updates/
-> [
  {
    action_object: {answer_object}
    actor: {user_object}
    id: 
    target: {question_object}
    timestamp:
    verb: "answered"
  }
]
  
Later: ?timestamp_gt= 2015-02-27T14:13:25Z

Comment 5

[Anthony Ricaud (:rik)]

I have the functionality working and some unit tests. I'm missing one functionality missing but I'll open a bug and we'll see in triage if this is a blocker.
I still have some unit tests to write and then cleanup the code.
My current progress is at https://github.com/Rik/buddyup/tree/realtime-1129453.

Comment 6

[Anthony Ricaud (:rik)]

I've updated my branch with new tests. I lost some time today with the test harness being broken. Writing tests for QuestionController was also a bit involved because those are the first ones. Everything is here now, I just need to clean the code to pass jshint, remove console.log calls and that kind of stuff. I'll have this in review tomorrow morning.

Comment 7

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla/buddyup/pull/106

Comment 8

[Rehan Dalal (Inactive)]

Comment on attachment 8573862 [details] [review]
https://github.com/mozilla/buddyup/pull/106

couple of nits, but once those are fixed. r+

Comment 9

[Anthony Ricaud (:rik)]

https://github.com/mozilla/buddyup/commit/03a9c2d7bdd7084438df78069a273bbfefd0a955