1129475 - Fix failure in test_sms_notification.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

Test test_sms_notification.py is failing in latest mozilla-central: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/3/HTML_Report/

I've been able to reproduce the failure locally. The test seems to fail because of changes in https://github.com/mozilla-b2g/gaia/commit/3912b4b5594688758c248f825020ed184df1e69f.
If I explicitly set message=message in https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/system/app.py#L45, the test works fine. 

Traceback (most recent call last):
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/.env/local/lib/python2.7/site-packages/marionette_client-0.8.7-py2.7.egg/marionette/marionette_test.py", line 283, in run
testMethod()
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_notification.py", line 26, in test_sms_notification
message="Notification did not appear. SMS database dump: %s " % self.data_layer.get_all_sms())
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/tests/python/gaia-ui-tests/gaiatest/apps/system/app.py", line 45, in wait_for_notification_toaster_displayed
expected.element_displayed(*self._notification_toaster_locator), message)
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/.env/local/lib/python2.7/site-packages/marionette_client-0.8.7-py2.7.egg/marionette/wait.py", line 120, in until
while not until(self.clock, self.end):
TypeError: 'str' object is not callable

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] viorelaioia:bug_1129475 to mozilla-b2g:master

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8559223 [details] [review]
[PullReq] viorelaioia:bug_1129475 to mozilla-b2g:master

Thanks for the quick fix viorela.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/df0cef4dab3b8db7057a0f82059f7260bc27e0e9