112951 - Link properties and spelling dialogs - listbox (tree) height is not set correctly from "rows" or "min-height" style attribute settings

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[andreww]

if you have many anchors in a page, the listbox text overflows the area 
allocated to it in the link properties dialog.

Comment 1

[andreww]

Attachment: creen shot of problem

screen shot of problem

Comment 2

[Charles Manske]

Thanks for filing this for me! I've been distracted and forgot to do it since we
talked.

Comment 3

[andreww]

cc'ing some folks who might know more about what's going on.

Comment 4

[Charles Manske]

*** Bug 112895 has been marked as a duplicate of this bug. ***

Comment 5

[Charles Manske]

*** Bug 103621 has been marked as a duplicate of this bug. ***

Comment 6

[andreww]

note to self - construct a simpler test case xul file.

Comment 7

[Charles Manske]

Note: The XUL for the Link Properties dialog "listbox" is:
        <tree rows="4" class="list" id="NamedAnchorList"
onselect="SelectNamedAnchor()" style="min-height: 4em">
          <treecolgroup><treecol flex="1"/></treecolgroup>
The <treechildren> ... <treecell> members are added at runtime.
The basic issue is that neither the "rows" attribute nor the setting of
min-height by the style attribute seem to work. The actual height of the box 
around the entire tree seems to be about 2.5em (Modern skin), thus the last 2 
items in the list draw outside the enclosing box.
Note that the Spell Check dialog also has this problem (there, rows="8" and I 
also set min-height on the tree at 8em), this is a bugscape bug.

Comment 8

[Charles Manske]

improving the summary

Comment 9

[TucsonTester1]

this was also reproduced on Mac OS X build 2001121805.80.

Comment 10

[Charles Manske]

Modified summary to add "Spelling" dialog, since that shows the same problem

Comment 11

[Charles Manske]

*** Bug 111312 has been marked as a duplicate of this bug. ***

Comment 12

[andreww]

Setting dependancy. I belive this issue should disappear when  listbox is 
implemented.

Comment 13

[Olga]

Bug 111312 for Mail Client is marked as duplicate of this one. This is just a
note not to forget to test Mail also when verify it from Browser.

Comment 14

[Charles Manske]

Correcting dependency bug number :)

Comment 15

[[e-mail]]

There are old styles in EditorDialogs.css for tree.list which set borders and
dimensions. If you remove them then the dialog displays perfectly.

Comment 16

[Charles Manske]

Thanks, Neil! While we should convert to the new "list" widget when available,
we have a fix now for this problem.

Comment 17

[Charles Manske]

Attachment: Remove bad CSS rules and extra style attributes in dialogs

Note that in the spelling dialog, there's a problem with sizing the dialog
if we simply remove the CSS in editorDialog.css -- buttons on bottom are cut
off.
Changing number of rows to 6 fixes this (that is what we had originally
anyway).

Comment 18

[Charles Manske]

Neil: review please?

Comment 19

[Charles Manske]

Attachment: Updated patch: Remove style in both lists in EdLinkProps.xul

Comment 20

[andreww]

Comment on attachment 63605 [details] [diff] [review]
Updated patch: Remove style in both lists in EdLinkProps.xul

looks good to me. Removing inline styles is always a plus!

r=andreww

Comment 21

[Joe Hewitt (gone)]

Comment on attachment 63605 [details] [diff] [review]
Updated patch: Remove style in both lists in EdLinkProps.xul

sr=hewitt

Comment 22

[Charles Manske]

checked in

Comment 23

[michael wendell]

Verified on trunk build 2002013003.

If anyone is still seeing this problem, please reopen this bug.