1129520 - [RTL][Selection] When selecting something in a check mark context menu, the text will move

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Context Menu Selection Logcat

Description:
Test will move to the right when selected, if in a selection menu that contains check marks to show selection. Menus such as add smart collection to homescreen, Selecting Usage reset dates, selecting days an alarm should ring, etc.


Repro Steps:
1) Update a Flame to 20150204010225
2) Change language to RTL (Arabic: عربي)
3) Open a context menu with check mark selection Ex: add smart collection to homescreen menu
4) Select an option

Actual:
The text will be shifted to the right when selected

Expected:
The text highlights blue, but does not move

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150204010225
Gaia: dfebaaa8aab43470f482d09d71137bab840c3ae9
Gecko: 0c2f7434c325
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 10/10
See attached: Logcat, Video - http://youtu.be/EFSF1pyXUKI

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 2.2

The text will be shifted to the right when selected

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150204002509
Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gecko: 8669c26fd4a5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Guillaume, please take a look.

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] gmarty:Bug-1129520-RTL-selected-items-on-drop-down-menus to mozilla-b2g:master

Comment 4

[Guillaume Marty [:gmarty]]

Comment on attachment 8561944 [details] [review]
[PullReq] gmarty:Bug-1129520-RTL-selected-items-on-drop-down-menus to mozilla-b2g:master

Another small one for you Kevin!

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8561944 [details] [review]
[PullReq] gmarty:Bug-1129520-RTL-selected-items-on-drop-down-menus to mozilla-b2g:master

Seems to be working fine for me. Thanks.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/7ec030ee2bdd2e063435df027ef83da745254393

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8561944 [details] [review]
[PullReq] gmarty:Bug-1129520-RTL-selected-items-on-drop-down-menus to mozilla-b2g:master

Requesting uplift on this RTL fix.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Papercut when using select box and in RTL.
[Testing completed]: Manual testing (small css change only).
[Risk to taking this patch] (and alternatives if risky): Small css change, low risk.
[String changes made]: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e4876368312ade0620956ea6d8064e190939e3c6

Comment 9

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified Fixed on 3.0

If the user selects an item on a check mark menu, the text will highlight properly without moving

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150211010216
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
------------------------------------------------------------------------------------------------
Adding verifyme keyword for this bug to be checked on 2.2

Comment 10

[Coler]

This issue has been verified successfully on Flame 2.2.
Reproduce rate:0/5
Attachment:Verify_RTL.mp4

Flame 2.2 build:

Gaia-Rev        791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5dec207fcbeb
Build-ID        20150212002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150212.042208
FW-Date         Thu Feb 12 04:22:18 EST 2015
Bootloader      L1TC000118D0

Comment 11

[Coler]

Attachment: Verify_RTL.MP4

Comment 12

[Sue]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15437/