1129577 - [mozdevice] Triggering drags occasionally interpreted as taps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

When using mozdevice to trigger a drag via:

device.input.drag(250, 250, 250, 350, 10, 150)

sometimes the drag is interpreted by the touch system as a tap instead. To make this more efficient, we should provide a configurable property which can allow us to override the optimal touch frequency for a given device.

With a configurable touch frequency, we can then consume this in Raptor for a smarter drag.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/3

Comment 2

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/11

Will not land until next mozdevice release.

Comment 3

[Robert Wood [:rwood]]

Comment on attachment 8559308 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/3

LGTM and tested in conjunction with the raptor PR in this bug. Ran the launch test on flame and emulator.

Comment 4

[:Eli Perelman]

Merged. Publish mozdevice@1.1.2 and gaia-raptor@0.4.1.

Comment 5

[GitHub Autolander Bot]

Attachment: Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/3

Comment 6

[:Eli Perelman]

Comment on attachment 8559415 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/3

Time to bust out the rubber stamp.

Comment 7

[:Eli Perelman]

Comment on attachment 8559415 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/3

Nevermind, going to kill 2 birds with one stone on another patch.