Closed
Bug 1129605
Opened 10 years ago
Closed 10 years ago
Fix consumers in /mail and /mailnews that call Map/Set/WeakMap constructors without "new"
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 38.0
People
(Reporter: philip.chee, Assigned: aryx)
References
Details
Attachments
(1 file)
|
5.71 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1108930 +++
(similar to bug 980962)
Before fixing bug 1062075 and bug 1083752,
need to add "new" to all of those calls in tree.
I can see about 2 occurrences of var X = Map() in /mailnews and one in /suite.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8559946 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8559946 [details] [diff] [review]
patch, v1
Review of attachment 8559946 [details] [diff] [review]:
-----------------------------------------------------------------
These look good to me! r=mkmelin
Attachment #8559946 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Comment 4•10 years ago
|
||
checkin-needed, or do you want to land it yourself?
Flags: needinfo?(archaeopteryx)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Pushed as http://hg.mozilla.org/comm-central/rev/39f54c7e9e27 - had been waiting for greener XPCshell tests before.
Flags: needinfo?(archaeopteryx)
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
Target Milestone: --- → Thunderbird 38.0
You need to log in
before you can comment on or make changes to this bug.
Description
•