Closed Bug 1129624 Opened 10 years ago Closed 10 years ago

Refactor the function to get download links

Categories

(www.mozilla.org :: Bedrock, enhancement)

Product:
www.mozilla.org
Component:
Bedrock
Version:
Production
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kohei, Assigned: kohei)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [kb=1652819])

Attachments

(1 file, 2 obsolete files)

pull request
44 bytes, text/x-github-pull-request
Details | Review
+++ This bug was initially created as a clone of Bug #1096393 +++ Bug 1096393 updated the Developer Edition download buttons on the channel page to use the bouncer (download.m.o). The /developer/all/ download page could also use the bouncer like the /beta/all/ page. I'll send a PR later.
Attached file pull request (obsolete) —
* Merge firefox/firefox_details.py and mozorg/helpers/download_buttons.py * Update Firefox Developer Edition download links to use the bouncer
Component: Pages & Content → Bedrock
Summary: Update Firefox Developer Edition download links → Refactor the function to get download links
* Prep for Windows 64 builds
Blocks: download-buttons, mozorg-win64
Attached file pull request (obsolete) —
Attachment #8559418 - Attachment is obsolete: true
Blocks: 836462, 112339
hm, wrong bug...
Blocks: 1123399
No longer blocks: 112339
No longer blocks: mozorg-win64
Attached file pull request —
Attachment #8564863 - Attachment is obsolete: true
Blocks: 1139961
I have verified download links for dev edition, /developer for win32 & osx, /aurora for win32 & osx, all versions for en-US & non-en-US. Linux testing is delayed as I have issues with the VM - hope to fix that or clarify today.
Verified with linux also - everything looks good. Clarification, tested: https://www-demo1.allizom.org/en-US/firefox/channel/#aurora & https://www-demo1.allizom.org/en-US/firefox/developer/; on both /en-US and another locale.
Awesome. Thank you!
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/b3579aa67bfe5bf4e58127c2e809b4ba512b2c24 Fix Bug 1129624: Refactor get_download_url https://github.com/mozilla/bedrock/commit/a3796bb451c6d525e2e61e64e6f53e50beadeeac Merge pull request #2871 from mozilla/kyoshino-bug-1129624-refactor-download-links Fix Bug 1129624 - Refactor the function to get download links
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 1149620
Depends on: 1151140
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: