Provide an indication to the user when auto-complete is suggesting saved logins

VERIFIED FIXED in Firefox 52

Status

()

Toolkit
Password Manager
--
enhancement
VERIFIED FIXED
3 years ago
7 months ago

People

(Reporter: rfeeley, Assigned: MattN)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 verified, firefox53 verified)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
So some forms, like ones featuring autocomplete=off, the user needs to enter a username to retrieve and fill stored credentials. In the auto-compelete results, we should signal which of the results will also fill in the password by including the key icon.

In the auto-complete tab of the LucidChart.
(Reporter)

Updated

3 years ago
Depends on: 1128683
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1189618
This is especially important when showing the autocomplete popup on a password field since we need to make it clear that we're not literally going to fill in the visible username from the autocomplete row into the password field.

Unduping so we can separate the icon from the footer work.
Assignee: nobody → MattN+bmo
Blocks: 1189618
Status: RESOLVED → REOPENED
status-firefox52: --- → affected
status-firefox53: --- → affected
No longer depends on: 1128683
Resolution: DUPLICATE → ---
Status: REOPENED → ASSIGNED
Comment hidden (mozreview-request)
Ryan, does this look okay to you? I think we should do the footer too but wanted to split up the work (due to comment 2): https://reviewboard.mozilla.org/r/94504/file/396/
Flags: needinfo?(rfeeley)
I'm trying to follow the design of the history icon in the search box when there is a search term from your search history.

Comment 6

9 months ago
mozreview-review
Comment on attachment 8812974 [details]
Bug 1129629 - Provide an indication to the user when auto-complete is suggesting saved logins.

https://reviewboard.mozilla.org/r/94504/#review94922

Looks solid to me. Thanks MattN!
Attachment #8812974 - Flags: review?(mconley) → review+
Bug 1318787 is an example of user confusion/alarm within a day or two of landing since the password autocomplete popup looks like other ones currently but acts differently. By making the popup look different I think it would communicate that it may work differently too.
(Reporter)

Comment 8

9 months ago
mozreview-review
Comment on attachment 8812974 [details]
Bug 1129629 - Provide an indication to the user when auto-complete is suggesting saved logins.

https://reviewboard.mozilla.org/r/94504/#review95364

Ship It!

Comment 9

9 months ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/089cb9e78d4a
Provide an indication to the user when auto-complete is suggesting saved logins. r=mconley,rfeeley

Comment 10

9 months ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcbb8882491f
Update test_user_autocomplete_result.js style checks. r=bustage

Comment 11

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/089cb9e78d4a
https://hg.mozilla.org/mozilla-central/rev/fcbb8882491f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago9 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Reporter)

Updated

9 months ago
Flags: needinfo?(rfeeley)
Comment on attachment 8812974 [details]
Bug 1129629 - Provide an indication to the user when auto-complete is suggesting saved logins.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1304224 - Insecure field warning
[User impact if declined]: Users won't understand what the autocomplete dropdown on a password field is for.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes, by devs, not QA
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: 
[Is the change risky?]: No
[Why is the change risky/not risky?]: straightforward showing of an icon beside the result
[String changes made/needed]: None
Attachment #8812974 - Flags: approval-mozilla-aurora?
Comment on attachment 8812974 [details]
Bug 1129629 - Provide an indication to the user when auto-complete is suggesting saved logins.

add visual clue for saved login auto-complete, for aurora52
Attachment #8812974 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/a858ae07d7a4
status-firefox52: affected → fixed
Successfully managed to reproduce this bug on Nightly 38.0a1 (2015-02-04) from Ubuntu 16.04 (64 Bit)

This issue is now Verified as Fixed on Latest Firefox Nightly 53.0a1 (2016-12-16) (Build ID: 20161216030207) and also Verified as Fixed on 

Latest Firefox Developer Edition 52.0a2 (2016-12-16) (64-bit) (Build ID: 20161216101750)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
OS: Linux 4.4.0-51-generic; Ubuntu 16.04
QA Whiteboard: [bugday-20161214]
I have reproduced this bug with Nightly 38.0a1 (2015-02-04) on Windows 7 , 64 Bit !

This bug's fix is verified with latest Aurora and  latest  Nightly 

Build  ID  : 20161221004017
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

Build  ID  : 20161221030226
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
[bugday-20161221]
Thanks!
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
status-firefox53: fixed → verified
Created attachment 8830113 [details]
lock and key1.png

Hi Philipp,

We discussed this over vidyo a bit - the combination of a lock with a strike through and a key icon next to each other is odd, when you consider the physical objects.  You mentioned we may consider changing the iconography.  Have you had more time to think about this?  Should we leave things as is, since, although this combination doesn't make sense in the physical world, they may make sense in a browser?

Thanks!
Flags: needinfo?(philipp)
Created attachment 8830114 [details]
lock and key2.png
(Reporter)

Comment 20

7 months ago
For reference: https://www.wired.com/2016/11/googles-chrome-hackers-flip-webs-security-model/

Tanvi: Replacing all instances the lock icon in the browser is not a quick fix, if shipping soon if your aim.
(In reply to Ryan Feeley [:rfeeley] from comment #20)
> For reference:
> https://www.wired.com/2016/11/googles-chrome-hackers-flip-webs-security-
> model/
> 
> Tanvi: Replacing all instances the lock icon in the browser is not a quick
> fix, if shipping soon if your aim.

Yes replacing the lock will require some user testing and take some time.  I do like the key in the url bar for passwords though.  I wonder if we should just change the key in the autocomplete drop down.  Or we can do nothing.
I think using them side by side is OK. I agree that it might not be the most perfect solution, but I'm also pretty sure that it will lead to little confusion in real-world scenarios.
Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.