Closed Bug 1129665 Opened 5 years ago Closed 4 months ago

Convert Mozmill test 'functional/testTabbedBrowsing/testOpenInBackground.js' to Marionette


(Testing :: Firefox UI Tests, defect, P2)



(Not tracked)



(Reporter: whimboo, Assigned: galgeek)




(1 file)

52 bytes, text/x-github-pull-request
: feedback+
Details | Review
This bug will cover the necessary work to do to convert the following test into Marionette.
Here my feedback after looking at this test:

* This test is similar to the test we cover in bug 1129658. It only opens the same tabs in the background.

* I see this test valuable given that our unit tests do not cover the usage of
middle click on a link and nor using its context menu.

* I don't see what this specific close tab test is helping us here, which
indeed not even fit into this test. So we want to remove those lines.

So what to do in raw steps:

* Ensure the pref to load tabs in the background is set to true
* Open the test page 
* Check that opening a new tab via the context menu works and it opens in the background
* Switch to the new tab and back to the original tab
* Check that opening two more tabs via the context menu works (lets not keep the
for loop for all)
* Check that the tabs have been opened in the right order by checking the id
element in the web page
Assignee: nobody → galgeek
Depends on: 1097705
Priority: P1 → P2
Attached file github pull request
I don't find examples of other Firefox ui tests accessing a context menu, and I have yet to figure it out. Is this otherwise a good start?
Attachment #8681670 - Flags: feedback?(hskupin)
(In reply to Barbara Miller (:galgeek) from comment #2)
> I don't find examples of other Firefox ui tests accessing a context menu,

This is something Tareq currently is working on via bug 1121710. So maybe lets wait some days for its inclusion in this test.
QA Contact: hskupin
Comment on attachment 8681670 [details] [review]
github pull request

I made some comments on the PR but as a starter it looks fine to me. I would suggest doing it more data driven to reduce the amount of redundant (duplicated) lines.
Attachment #8681670 - Flags: feedback?(hskupin) → feedback+
Product: Mozilla QA → Testing

There is good coverage in browser chrome tests so this is not needed, and we are also going to remove the firefox-ui tests.

Closed: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.