Closed
Bug 1129666
Opened 9 years ago
Closed 9 years ago
Revision links in graphs view don't actually work
Categories
(Tree Management :: Perfherder, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: wlach, Assigned: wlach)
References
Details
Attachments
(1 file)
Oops. This is just a bug.
|
Assignee | |
Comment 1•9 years ago
|
||
This one's pretty straightforward, we were using the wrong variable.
Assignee: nobody → wlachance
Attachment #8559406 -
Flags: review?(tojonmz)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8559406 [details] [review] Fix revision hyperlinks in graphs This looks good to me, and wlach has tested it locally and it's working as expected.
Attachment #8559406 -
Flags: review?(tojonmz) → review+
|
||
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/1bbea19775fd356cde11d48394bb737bfef0f756 Bug 1129666 - Fix revision hyperlinks in graphs https://github.com/mozilla/treeherder-ui/commit/0ee92b9b8ebce413431d7edf4f7ac9c351128565 Merge pull request #356 from wlach/1129666 Bug 1129666 - Fix revision hyperlinks in graphs
|
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 4•9 years ago
|
||
Marking Fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•9 years ago
|
||
Still to be pushed to prod, but marking Verified and working fine on stage.
Status: RESOLVED → VERIFIED
|
|
||
Comment 6•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/0eaef35195a801808c398dd78bf05558ac0aa8fb Bug 1129666 - Fix revision hyperlinks in graphs https://github.com/mozilla/treeherder/commit/7e91b6f046dcc19cbc6493287e32946c642c0cb0 Merge pull request #356 from wlach/1129666 Bug 1129666 - Fix revision hyperlinks in graphs
You need to log in
before you can comment on or make changes to this bug.
Description
•