Closed
Bug 1129696
Opened 9 years ago
Closed 9 years ago
OS X CoreLocation provider: NSTimer not released
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: garvan, Assigned: garvan)
References
Details
Attachments
(1 file)
|
2.37 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
no-ARC, this must be released: https://dxr.mozilla.org/mozilla-central/source/dom/system/mac/CoreLocationLocationProvider.mm#61
This is very likely to crash. Also I removed my note about not having to call [timer invalidate] on single-shot timers after execution, it doesn't matter, it is a no-op, and code is cleaner just to call it.
Attachment #8559485 -
Flags: review?(dougt)
|
||
Updated•9 years ago
|
Attachment #8559485 -
Flags: review?(dougt) → review+
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75b9cebe5268
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75b9cebe5268
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•