1129718 - Build error in Factory.cpp when using --enable-debug and --disable-logging

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[cajbir (:cajbir)]

When building with the following in .mozconfig I have an error in Factor.cpp:

ac_add_options --enable-tests
ac_add_options --enable-gstreamer
ac_add_options --enable-debug
ac_add_options --disable-logging

The error is:

In file included from obj-x86_64-unknown-linux-gnu/gfx/2d/Unified_cpp_gfx_2d0.cpp:92:0:
 gfx/2d/Factory.cpp:56:2: error: ‘PRLogModuleInfo’ does not name a type
 GFX2D_API PRLogModuleInfo *
    ^
 In the directory  obj-x86_64-unknown-linux-gnu/gfx/2d

Comment 1

[cajbir (:cajbir)]

Attachment: Fix

Use PR_LOGGING only to determine whether to use logging. This is the same conditional define used in gfx/2d/Logging.h to include the declaration of the function.

Comment 2

[cajbir (:cajbir)]

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=53d37ef990ef

Comment 3

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6aa2335b0f0f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6aa2335b0f0f

Comment 5

[Michael Shigorin]

TWIMC: the same build error pops up with seamonkey-2.38 given --disable-logging (it's also --disable-debug over here at the moment); the trivially updated patch along with a similar hunk for gfx/2d/Logging.h didn't quite suffice so my current workaround is --enable-logging.