1129721 - Link to Adobe CDM's license page from Add-ons Manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Chris Peterson [:cpeterson]]

Adobe needs to give us the URL to their CDM license.

Comment 1

[Stephen A Pohl [:spohl]]

Joe Steele confirmed in bug 1130682 that the EULA URL will be the following:

> EULA URL:  http://help.adobe.com/en_US/primetime/drm/HTML5_CDM_EULA/index.html

Joe, will you detect the user's locale on your end and redirect to a localized version of the EULA? Or do you need us to change the "en_US" in the URL and replace it with the correct locale?

Comment 2

[Joe Steele]

Ah -- good point. If you can replace the "en_US" with the correct locale that would be great. I will let our tech ops know what to expect.

Comment 3

[Chris Peterson [:cpeterson]]

Joe, do you know which languages Adobe will translate the EULA into?

Firefox is available in 90 locales [1] (including Esperanto :). I assume Adobe won't translate the EULA to 90 languages, so beware that your server should expect URL requests that are 404 and should be redirected to en_US or something appropriate.

[1] https://www.mozilla.org/en-US/firefox/all/
[2] http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/36.0b8/win32/

Comment 4

[Justin Dolske [:Dolske]]

Is the URL available at an https:// URL? I think we'd very much prefer to have links using secure connections whenever possible.

Unfortunately https://help.adobe.com/ just yields a browser error page, as the cert is sending is only valid for some Akamai domains. Perhaps that's fixable?

Comment 5

[Joe Steele]

Asking both questions internally -- stay tuned.

Comment 6

[Stephen A Pohl [:spohl]]

Georg correctly pointed out that we'll need the ability to localize the string for the link to the license in the addons manager, i.e. "License Information". I'll tackle this as part of this bug here.

Comment 7

[Chris Peterson [:cpeterson]]

Joe says that Adobe does not usually localize their licenses, but the license landing page can be localized based. on the client locale.

Joe: would Adobe prefer to identify the client locale using the "Accept-Language" HTTP request header or a locale string in the license URL?

Comment 8

[Stephen A Pohl [:spohl]]

Attachment: 1. Add ability to localize license info and URL

This adds the ability to localize the license info text ("License information") in the addons manager as well as the actual license URLs. I don't know if OpenH264 will eventually host their licenses on a remote server, so I have to assume that we will support both localized (added to plugins.properties) and non-localized (embedded directly in GMPProvider.jsm) license URLs for now.

I will add the actual URL for Adobe EME in a subsequent patch once we get the answers to comment 3, comment 4 and comment 7.

There are many different ways to solve this. Georg, what do you think about this approach?

Comment 9

[Stephen A Pohl [:spohl]]

(In reply to Chris Peterson [:cpeterson])
> OS: Mac OS X → Windows Vista

Was this supposed to be "All" (same in bug 1130682)?

Comment 10

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8566500 [details] [diff] [review]
1. Add ability to localize license info and URL

Review of attachment 8566500 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/locales/en-US/chrome/plugins.properties
@@ +27,5 @@
>  openH264_description=Play back web video and use video chats.
>  
>  eme-adobe_name=Primetime Content Decryption Module provided by Adobe Systems, Incorporated
>  eme-adobe_description=Play back protected web video.
> +eme-adobe_license_url=

I don't think we will need to localize the URL.
E.g. we can just submit the locale as part of the URL if needed, etc.

::: toolkit/mozapps/extensions/internal/GMPProvider.jsm
@@ +545,5 @@
> +    // localized license URL.
> +    let licenseURL = aPlugin.licenseURL;
> +    try {
> +      licenseURL = pluginsBundle.GetStringFromName(aPlugin.licenseURL);
> +    } catch (ex) { }

We should avoid always hitting the string bundle, but if we don't localize the URL that point is moot.

Comment 11

[Stephen A Pohl [:spohl]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #10)
> Comment on attachment 8566500 [details] [diff] [review]
> 1. Add ability to localize license info and URL
> 
> Review of attachment 8566500 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/locales/en-US/chrome/plugins.properties
> @@ +27,5 @@
> >  openH264_description=Play back web video and use video chats.
> >  
> >  eme-adobe_name=Primetime Content Decryption Module provided by Adobe Systems, Incorporated
> >  eme-adobe_description=Play back protected web video.
> > +eme-adobe_license_url=
> 
> I don't think we will need to localize the URL.
> E.g. we can just submit the locale as part of the URL if needed, etc.


Okay, since we'll be uplifting things to FF 37 I've gone ahead and filed bug 1134831 to cover the "License information" string. We'll handle the license URL here, and will submit the locale as part of the URL if necessary.

Comment 12

[Stephen A Pohl [:spohl]]

Attachment: Patch

Comment 13

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8568077 [details] [diff] [review]
Patch

I don't see myself getting to other reviews before i leave, sorry.
Dave, can you maybe review this?

Comment 14

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/fx-team/rev/6e201e1c7102

Comment 15

[Stephen A Pohl [:spohl]]

Comment on attachment 8568077 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Adobe EME
[User impact if declined]: The addons manager will not display a link to the Adobe EME license.
[Describe test coverage new/current, TreeHerder]: This was a simple URL change. Successfully tested locally.
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 16

[Stephen A Pohl [:spohl]]

Comment on attachment 8568077 [details] [diff] [review]
Patch

This will need a separate patch for beta. Clearing a?.

Comment 17

[Stephen A Pohl [:spohl]]

Attachment: Patch for beta

Approval Request Comment
[Feature/regressing bug #]: Adobe EME
[User impact if declined]: The addons manager will not display a link to the Adobe EME license.
[Describe test coverage new/current, TreeHerder]: This was a simple URL change. Successfully tested locally.
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 18

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8570649 [details] [diff] [review]
Patch for beta

Trivial change. Beta+

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f4d508e1c7d

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7bbbe05d19d4

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6e201e1c7102

Comment 22

[Chris Peterson [:cpeterson]]

Joe: the Primetime EULA page [1] is still 404. We will need a real web page here before we start public beta testing. Do you have an ETA from Adobe Legal?

[1] http://help.adobe.com/en_US/primetime/drm/HTML5_CDM_EULA/index.html

Comment 23

[Joe Steele]

This has been working for some time now. Are you still seeing an issue?

Comment 24

[Chris Peterson [:cpeterson]]

Thanks, Joe. The link works for me now. I'm resolving this bug as "verified fixed".