Closed Bug 1129771 Opened 8 years ago Closed 8 years ago

Intermittent test_ocsp_stapling.js,test_ocsp_stapling_expired.js | Test timed out

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: philor, Assigned: keeler)

References

Details

Attachments

(1 file)

patch
1.74 KB, patch
Cykesiopka
: review+
Details | Diff | Splinter Review 
This may turn out to be OS X 10.10 specific, since I know I've seen it at least once before there (10.10 is currently only run on try, only with  "try: -b do -p macosx64 -u xpcshell[10.10] -t none" to get this suite, but before long it will be replacing 10.8).
Summary: Intermittent test_ocsp_stapling.js | Test timed out → Intermittent test_ocsp_stapling.js,test_ocsp_stapling_expired.js | Test timed out
This is failing 50+% of the time on OSX 10.10 opt now that it's enabled in production. I'm probably going to have to hide 10.10 xpcshell at this point (or disable my way to victory) given the failure rate. Dave, do you have the ability to look into this fairly soonish?
Flags: needinfo?(dkeeler)
Blocks: 1121199
Attached patch patch — — Splinter Review 
This appears to fix it for me on my local 10.10 machine.
Ryan, what's the try syntax to test this on 10.10 - would "try: -b do -p macosx64 -u xpcshell[10.10] -t none" work?
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Flags: needinfo?(dkeeler) → needinfo?(ryanvm)
Attachment #8572864 - Flags: review?(cykesiopka.bmo)
(In reply to David Keeler [:keeler] (use needinfo?) from comment #29)
> Ryan, what's the try syntax to test this on 10.10 - would "try: -b do -p
> macosx64 -u xpcshell[10.10] -t none" work?

Oh, nevermind - just re-read comment 0.
Flags: needinfo?(ryanvm)
Comment on attachment 8572864 [details] [diff] [review]
patch

Review of attachment 8572864 [details] [diff] [review]:
-----------------------------------------------------------------

r+ pending green try push.

::: security/manager/ssl/tests/unit/head_psm.js
@@ +255,5 @@
>      this.defer = Promise.defer();
>      let sts = Cc["@mozilla.org/network/socket-transport-service;1"]
>                  .getService(Ci.nsISocketTransportService);
>      this.transport = sts.createTransport(["ssl"], 1, aHost, REMOTE_PORT, null);
> +    this.transport.connectionFlags |= Ci.nsISocketTransport.DISABLE_IPV6;

Maybe add a brief comment on why we're doing this?
(Then again, the commit message is very clear on why, so no comment is fine as well).
Attachment #8572864 - Flags: review?(cykesiopka.bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/1e4b76918021
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox39: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
I filed bug 1235089 for picking up the oranges that are still coming in. Removing intermittent-failure keyword from this bug so people stop starring it.
Keywords: intermittent-failure
You need to log in before you can comment on or make changes to this bug.