Closed Bug 1129774 Opened 6 years ago Closed 6 years ago

nsBaseWidget::GetDeviceContext is unused

Categories

(Core :: Widget, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(6 files, 1 obsolete file)

39 bytes, text/x-review-board-request
jimm
: review+
Details
39 bytes, text/x-review-board-request
jimm
: review+
Details
39 bytes, text/x-review-board-request
jimm
: review+
Details
39 bytes, text/x-review-board-request
jimm
: review+
Details
39 bytes, text/x-review-board-request
jimm
: review+
Details
39 bytes, text/x-review-board-request
jimm
: review+
Details
No description provided.
Attached file MozReview Request: bz://1129774/roc (obsolete) —
/r/3357 - Bug 1129774. Remove unused nsBaseWidget::GetDeviceContext. r=jmathies

Pull down this commit:

hg pull review -r 627c18d164cd763aef068595107f06c20f11ab15
Comment on attachment 8559567 [details]
MozReview Request: bz://1129774/roc

/r/3357 - Bug 1129774. Remove unused nsBaseWidget::GetDeviceContext. r=jmathies
/r/3365 - Bug 1129774. Part 2: Remove nsBaseWidget::mContext. r=jmathies
/r/3367 - Bug 1129774. Part 3: Remove aContext parameter from BaseCreate and make it nonvirtual. r=jmathies
/r/3369 - Bug 1129774. Part 4: Remove aContext parameter from AttachViewToTopLevel. r=jmathies
/r/3371 - Bug 1129774. Part 5: Remove aContext parameter from nsIWidget::Create. r=jmathies
/r/3373 - Bug 1129774. Part 6: Remove aContext parameter from nsIWidget::CreateChild. r=jmathies

Pull down these commits:

hg pull review -r 012e98991a006c6a863ec491d2e98416870205b3
Comment on attachment 8559567 [details]
MozReview Request: bz://1129774/roc

/r/3357 - Bug 1129774. Remove unused nsBaseWidget::GetDeviceContext. r=jmathies
/r/3365 - Bug 1129774. Part 2: Remove nsBaseWidget::mContext. r=jmathies
/r/3367 - Bug 1129774. Part 3: Remove aContext parameter from BaseCreate and make it nonvirtual. r=jmathies
/r/3369 - Bug 1129774. Part 4: Remove aContext parameter from AttachViewToTopLevel. r=jmathies
/r/3371 - Bug 1129774. Part 5: Remove aContext parameter from nsIWidget::Create. r=jmathies
/r/3373 - Bug 1129774. Part 6: Remove aContext parameter from nsIWidget::CreateChild. r=jmathies

Pull down these commits:

hg pull review -r 012e98991a006c6a863ec491d2e98416870205b3
Attachment #8559567 - Flags: review?(jmathies)
Attachment #8559567 - Flags: review?(jmathies)
Comment on attachment 8559567 [details]
MozReview Request: bz://1129774/roc

https://reviewboard.mozilla.org/r/3355/#review2743

::: widget/nsIWidget.h
(Diff revision 2)
>       * container, attach a secondary listener and update the device

nit, this comment needs an update too.
Comment on attachment 8559567 [details]
MozReview Request: bz://1129774/roc

https://reviewboard.mozilla.org/r/3355/#review2745

Ship It!
Attachment #8559567 - Flags: review+
Attachment #8559567 - Attachment is obsolete: true
Attachment #8619320 - Flags: review+
Attachment #8619321 - Flags: review+
Attachment #8619322 - Flags: review+
Attachment #8619323 - Flags: review+
Attachment #8619324 - Flags: review+
Attachment #8619325 - Flags: review+
You need to log in before you can comment on or make changes to this bug.