Closed
Bug 1129780
Opened 9 years ago
Closed 9 years ago
Report the youngest sampled frame's line number if it has optimization info
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: shu, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
17.18 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
We need the specific line number that the optimization occurred on, else the info is unactionable. Since PCToLineNumber isn't free, I don't see the need to do this lookup on all leaf frames. So this patch only looks up the specific line number if it has optimization info.
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8559574 -
Flags: review?(kvijayan)
Reporter | ||
Comment 2•9 years ago
|
||
Changed the public API to hand out a JSScript and jsbytecode instead of just a line number.
Attachment #8559574 -
Attachment is obsolete: true
Attachment #8559574 -
Flags: review?(kvijayan)
Attachment #8560780 -
Flags: review?(kvijayan)
Updated•9 years ago
|
Attachment #8560780 -
Flags: review?(kvijayan) → review+
Comment 3•9 years ago
|
||
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=63c2c0fe808e since one of this changes caused hazard failures like: https://treeherder.mozilla.org/logviewer.html#?job_id=6873524&repo=mozilla-inbound harzard files are in https://ftp-ssl.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/mozilla-inbound-linux64-b2g-haz/20150222200529/
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf9681ea636e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•