Re-lookup JIT code return addr instead of caching the index for optimization info streaming

RESOLVED FIXED in Firefox 38

Status

()

Core
Gecko Profiler
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: shu, Unassigned)

Tracking

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
In bug 1127156 I saved both the return addr and the optimization info index into the circular buffer, since I thought, why look it up again?

I've since come around to only storing the addr and just re-lookup the optimization info index. Saves on circular buffer space and need to maintain one less tag.
(Reporter)

Comment 1

3 years ago
Created attachment 8559573 [details] [diff] [review]
Re-lookup JIT code return addr when stringifying optimization info instead of caching the index.

This saves us some circular buffer space.
Attachment #8559573 - Flags: review?(kvijayan)

Updated

3 years ago
Attachment #8559573 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/9ca32c3e11cb
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.