If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Unlazify initialization of some PLDHashTables

RESOLVED FIXED in Firefox 39

Status

()

Core
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
In bug 700914 and bug 1059056 we lazified the initialization of some PLDHashTables in cases where the tables often never had anything put into them. This avoided some unnecessary allocations.

But now that bug 1050035 has landed, PLDHashTable does this optimization itself, and we can simplify things by undoing the previous patches.
(Assignee)

Comment 1

3 years ago
Created attachment 8559585 [details] [diff] [review]
(part 1) - Instantiate nsDOMAttributeMap::mAttributeCache eagerly

Now that empty PLDHashTables don't allocate any entry storage, we can undo the lazification of RuleHash::m*Table from bug 700914. r=bz.
Attachment #8559585 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

3 years ago
Created attachment 8559586 [details] [diff] [review]
(part 2) - Instantiate nsDOMAttributeMap::mAttributeCache eagerly

Now that empty PLDHashTables don't allocate any entry storage, we can undo the
lazification of nsDOMAttributeMap::mAttributeCache from bug 1059056.
Attachment #8559586 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

3 years ago
Created attachment 8559590 [details] [diff] [review]
(part 1) - Instantiate RuleHash::m*Table eagerly

fix up the log message
Attachment #8559590 - Flags: review?(bzbarsky)
(Assignee)

Updated

3 years ago
Attachment #8559585 - Attachment is obsolete: true
Attachment #8559585 - Flags: review?(bzbarsky)
Comment on attachment 8559586 [details] [diff] [review]
(part 2) - Instantiate nsDOMAttributeMap::mAttributeCache eagerly

r=me
Attachment #8559586 - Flags: review?(bzbarsky) → review+
Comment on attachment 8559590 [details] [diff] [review]
(part 1) - Instantiate RuleHash::m*Table eagerly

r=me
Attachment #8559590 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

3 years ago
Depends on: 1050035
(Assignee)

Comment 6

3 years ago
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3d84265b196
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f75beaf3149f
https://hg.mozilla.org/integration/mozilla-inbound/rev/327a93e5cc39
https://hg.mozilla.org/mozilla-central/rev/f75beaf3149f
https://hg.mozilla.org/mozilla-central/rev/327a93e5cc39
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.