Closed Bug 1129786 Opened 7 years ago Closed 7 years ago

Unlazify initialization of some PLDHashTables

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(2 files, 1 obsolete file)

In bug 700914 and bug 1059056 we lazified the initialization of some PLDHashTables in cases where the tables often never had anything put into them. This avoided some unnecessary allocations.

But now that bug 1050035 has landed, PLDHashTable does this optimization itself, and we can simplify things by undoing the previous patches.
Now that empty PLDHashTables don't allocate any entry storage, we can undo the lazification of RuleHash::m*Table from bug 700914. r=bz.
Attachment #8559585 - Flags: review?(bzbarsky)
Now that empty PLDHashTables don't allocate any entry storage, we can undo the
lazification of nsDOMAttributeMap::mAttributeCache from bug 1059056.
Attachment #8559586 - Flags: review?(bzbarsky)
fix up the log message
Attachment #8559590 - Flags: review?(bzbarsky)
Attachment #8559585 - Attachment is obsolete: true
Attachment #8559585 - Flags: review?(bzbarsky)
Comment on attachment 8559586 [details] [diff] [review]
(part 2) - Instantiate nsDOMAttributeMap::mAttributeCache eagerly

r=me
Attachment #8559586 - Flags: review?(bzbarsky) → review+
Comment on attachment 8559590 [details] [diff] [review]
(part 1) - Instantiate RuleHash::m*Table eagerly

r=me
Attachment #8559590 - Flags: review?(bzbarsky) → review+
Depends on: 1050035
You need to log in before you can comment on or make changes to this bug.