1129799 - Add ability to select multiple countries in a single desktop snippet [Firefox]

Status: RESOLVED FIXED

(Snippets :: Service, defect)

Description

[Fabio Rios [:frios]]

Attachment: multi-select.jpg

We are currently limited to targeting one country per snippet. We would like to turn this field into a muti-select box so that it functions in the same way the "locales" field functions.

See attached mockup.

Date requested: 3/3/15

Let me know if you have any questions or concerns. Thank you.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Do you want this change on both Desktop and JSON (Android) Snippets?

Comment 2

[Fabio Rios [:frios]]

The need has been desktop, so I would suggest that one only. There's more good stuff on the road map, I would prefer we move on to those.

Jean, any specific foreseeable need to have on JSON?

Comment 3

[Jean Collings]

Hi Giorgos,

I actually would love to have it on JSON as well if it's not too time consuming. So if that's possible please do so. Thanks!

Jean

Comment 4

[Giorgos Logiotatidis [:giorgos]]

(In reply to Jean Collings from comment #3)
> I actually would love to have it on JSON as well if it's not too time
> consuming. 

For JSON we'll need to make some changes on Fennec as well. I calculate that to be a fairly easy change but we still need to request it from the Fennec team.

Here's what I suggest:
1. We already have a fix ready for Desktop snippets. We proceed with that as is.
2. Meanwhile we open a bug for the Fennec team requesting the change.
3. When Fennec is ready, we make the JSON change in Snippets Service.

The Fennec change will take couple of weeks to a couple of months if we ride all the trains. My take is that if meanwhile our service changes or gets absorbed by the Content Service Platform, the change on Fennec is still valuable and available for use.

If you agree with the plan I can file the needed bugs.

needinfo-ing Ben for his valuable input.

Comment 5

[Jean Collings]

Sounds good, thanks Giorgos!

Comment 6

[Ben (:bensternthal)]

Agree on plan and next steps. Go forth!

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/snippets-service

https://github.com/mozilla/snippets-service/commit/6e13d5f3ad1322516a24fc2623ccc3d167b27cd1
[bug 1129799] Multiple countries per snippet.

https://github.com/mozilla/snippets-service/commit/0a0efa48af1e5db8d89ccb3e7f3de163f57dfa78
Merge pull request #105 from glogiotatidis/1129799

[bug 1129799] Multiple Countries per Snippet

Comment 8

[Giorgos Logiotatidis [:giorgos]]

Now on production!

BTW Jean snippet pings include locale information. Do you want to add country code to the ping to be able to distinguish the pings, now that we support multiple countries per snippet?

Comment 9

[Jean Collings]

Yes please so should I ever want to see specific number of clicks per country from one snippet, that would be helpful.

Thanks!

Comment 10

[Fabio Rios [:frios]]

We already have data by country. Am I missing something?

Comment 11

[Giorgos Logiotatidis [:giorgos]]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1157141 

:frios does that answer your question?


BTW who's responsible for the metric service now?

Comment 12

[Jean Collings]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #11)
> Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1157141 
> 
> :frios does that answer your question?
> 
> 
> BTW who's responsible for the metric service now?

Giorgos, sweet! In terms of metrics I believe it's Josephine or Sheeri. Do I need to let them know or adjust anything? They are the ones that help me pull the metrics to Tableau. Let me know.

And it looks like the multiple country functionality is all ready to go. It's been tested and such? 

Thanks Giorgos!

Comment 13

[Giorgos Logiotatidis [:giorgos]]

(In reply to Jean Collings from comment #12)
> And it looks like the multiple country functionality is all ready to go.
> It's been tested and such? 

Yes, it's ready to go!