Closed Bug 1129805 Opened 5 years ago Closed 5 years ago

[Stingray] font-style of Smart Button text should be italic.

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: selee, Assigned: selee)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file, 1 obsolete file)

For all Smart Button texts, their font-style should be italic, so italic font-style should be given at smart-button/style.css .
We don't have to give italic font-style during using smart button.

diff --git a/tv_apps/tv_shared/components/smart-button/style.css b/tv_apps/tv_shared/components/smart-button/style.css
index 39ab00d..f3b2bb4 100644
--- a/tv_apps/tv_shared/components/smart-button/style.css
+++ b/tv_apps/tv_shared/components/smart-button/style.css
@@ -29,6 +29,7 @@ smart-button {
   background-repeat: no-repeat;
   background-size: 5.4rem auto;
   background-position: center center;
+  font-style: italic;

   transition-property: all;
   transition-timing-function: cubic-bezier(0.25, 0, 0, 1.0);
Attached file PR for master
Hi John,

Could you help to review my patch?
Thank you.
Assignee: nobody → selee
Status: NEW → ASSIGNED
Attachment #8560227 - Flags: review?(im)
Attachment #8560226 - Attachment is obsolete: true
Whiteboard: [ft:conndevices][Stingray-Branch]
Comment on attachment 8560227 [details] [review]
PR for master

looks good to me. BTW, I don't think we need to put to stingray-branch. Since they already removed the italic in their branch.
Attachment #8560227 - Flags: review?(im) → review+
landed on master : https://github.com/mozilla-b2g/gaia/commit/f0bb678ddbb5b481051a68890c775e0677c19294
      try-server : https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=ca4179ee7581
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices][Stingray-Branch] → [ft:conndevices]
You need to log in before you can comment on or make changes to this bug.