1129805 - [Stingray] font-style of Smart Button text should be italic.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Sean Lee [:seanlee][:weilonge]]

For all Smart Button texts, their font-style should be italic, so italic font-style should be given at smart-button/style.css .
We don't have to give italic font-style during using smart button.

diff --git a/tv_apps/tv_shared/components/smart-button/style.css b/tv_apps/tv_shared/components/smart-button/style.css
index 39ab00d..f3b2bb4 100644
--- a/tv_apps/tv_shared/components/smart-button/style.css
+++ b/tv_apps/tv_shared/components/smart-button/style.css
@@ -29,6 +29,7 @@ smart-button {
   background-repeat: no-repeat;
   background-size: 5.4rem auto;
   background-position: center center;
+  font-style: italic;

   transition-property: all;
   transition-timing-function: cubic-bezier(0.25, 0, 0, 1.0);

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] weilonge:TV_1129805 to mozilla-b2g:master

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Attachment: PR for master

Hi John,

Could you help to review my patch?
Thank you.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8560227 [details] [review]
PR for master

looks good to me. BTW, I don't think we need to put to stingray-branch. Since they already removed the italic in their branch.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

landed on master : https://github.com/mozilla-b2g/gaia/commit/f0bb678ddbb5b481051a68890c775e0677c19294
      try-server : https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=ca4179ee7581