1129837 - Remove generatedLocation from BreakpointActor.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Eddy Bruel [:ejpbruel]]

Attachment: patch

Now that BreakpointActors are stored in the BreakpointActorMap by original location we can remove the generated location from the BreakpointActor.

This patch is based on top of the one in bug 1129834.

Comment 1

[Eddy Bruel [:ejpbruel]]

Try push for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d24d497a88d

Comment 2

[James Long (:jlongster)]

I think we are still going to need this. In bug 1129834 you changed `_addScript` to run this original location through the source map, but we can't do that. I think we need to continue storing the generated location here so that we can access it on page load in `_addScript` and set it directly.

Comment 3

[James Long (:jlongster)]

Comment on attachment 8559682 [details] [diff] [review]
patch

Review of attachment 8559682 [details] [diff] [review]:
-----------------------------------------------------------------

This is a cascading r- from bug 1129834

Comment 4

[Eddy Bruel [:ejpbruel]]

Attachment: patch

Now that bug 1129834 has been resolved, this should be able to land as well. Here is a rebased patch.

Comment 5

[James Long (:jlongster)]

Comment on attachment 8568530 [details] [diff] [review]
patch

Review of attachment 8568530 [details] [diff] [review]:
-----------------------------------------------------------------

No problems here

Comment 6

[Eddy Bruel [:ejpbruel]]

Try run for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c53e5fa65b6

Comment 7

[Eddy Bruel [:ejpbruel]]

Try push looks green, landing on fx-team:
https://hg.mozilla.org/integration/fx-team/rev/7230951c2c5b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7230951c2c5b