I'm suddenly getting flaky returns using nsURIChecker, which used to work fine. Sometimes it crashes in asyncOpen on a valid url; if it doesn't crash, then when checking http://www.mozilla.org/nonexistant.html, it calls OnStartRequest with an http request status of 200 (should be 404 or something similar). This possibly should be two separate bugs; let me know if I should split them up. Send it back to me if I'm doing something wrong in nsURIChecker (but this used to work and the nsURIChecker code hasn't changed). To reproduce: use a build from this afternoon or later (I checked in some fixes to ComposerCommands.js), edit a file which contains links to http://www.mozilla.org/nonexistant.html http://www.mozilla.org/unix/customizing.html (I'll attach the document I've been using so you can just edit that), then do Debug->Check Links. When it crashes, here's the stack trace: #0 0x405868c1 in kill () at ../../../dist/include/string/nsAFlatString.h:68 #1 0x40299aa7 in pthread_setconcurrency () at eval.c:41 #2 0x4029bd31 in sem_destroy () at eval.c:41 #3 0x402980f4 in pthread_mutex_unlock () at eval.c:41 #4 0x40264923 in PR_Unlock (lock=0x8642f8c) at ptsynch.c:210 #5 0x40265340 in PR_ExitMonitor (mon=0x8642f88) at ptsynch.c:535 #6 0x408ce623 in nsSocketTransport::AsyncRead (this=0x8675198, aListener=0x8663974, aContext=0x0, aOffset=0, aCount=4294967295, aFlags=3, aRequest=0xbfffc7fc) at ../../../dist/include/xpcom/nsAutoLock.h:209 #7 0x40918215 in nsHttpConnection::ActivateConnection (this=0x8663970) at ../../../../dist/include/xpcom/nsCOMPtr.h:650 #8 0x40917544 in nsHttpConnection::SetTransaction (this=0x8663970, transaction=0x86efb88, caps=1 '\001') at nsHttpConnection.cpp:118 #9 0x409120f9 in nsHttpHandler::InitiateTransaction_Locked (this=0x815e300, trans=0x86efb88, ci=0x86895c8, failIfBusy=0) at nsHttpTransaction.h:72 #10 0x4090fdc7 in nsHttpHandler::InitiateTransaction (this=0x815e300, trans=0x86efb88, ci=0x86895c8) at nsHttpHandler.cpp:393 #11 0x4091f582 in nsHttpChannel::Connect (this=0x86dfb20, firstTime=1) at nsHttpHandler.h:77 #12 0x4092a7aa in nsHttpChannel::AsyncOpen (this=0x86dfb20, listener=0x86e0f18, context=0x0) at nsHttpChannel.cpp:1955 #13 0x408daed0 in nsURIChecker::AsyncCheckURI (this=0x86e0f10, aURI=0x86e0540 "http://www.mozilla.org/unix/customizing.html", aObserver=0x86d96b8, aCtxt=0x0, aRequestRet=0xbfffcd40) at ../../../dist/include/xpcom/nsCOMPtr.h:650 [ ... ]
I wonder if we might have been trying to access the wrong uri at some point? The uri ref object needs the patch in bug 115318, and after applying that patch, I don't seem to be seeing the netlib crashes any more (in the few tests I've run). I'd be interested to hear whether anyone else sees them after applying that patch.
akk: can we close this bug?
I don't seem to be seeing it any more. Charley, is it working for you with the patch in bug 115318? If so, we can close this bug, and can I ask you two for a review/sr for the 115318 patch?
marking WORKSFORME per akkana's comments. please reopen if the problem re- appears.