112986 - Spaces get introduced when composing message in draft

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Suresh Duddi (gone)]

I use text compose (not html). Save it (ctrl-s) in drafts. Double click on the
message in drafts to edit it again.

before
- http://bugzilla.mozilla.org/show_bug.cgi?id=112470
   Make MOZ_TIMELINE and MOZ_TRACE_MALLOC default

after
- http://bugzilla.mozilla.org/show_bug.cgi?id=112470
    Make MOZ_TIMELINE and MOZ_TRACE_MALLOC default

Look at the line starting with spaces. The "Make" is shifted by one character.
This happenes when we save the message into draft too.

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 114479 has been marked as a duplicate of this bug. ***

Comment 2

[Paulo Castro]

This bug is not limited to Windows 2000. It also happens, at least, in Linux and
Windows XP. Also, it doesn't happen only in `drafts' folder but also in `unsent
messages' folder. Prior to knowing about the existence of this bug report
(112986), I wrote a web page with 2 gifs to try to explain the bug better. So if
you find it useful, please visit it at http://br.geocities.com/peddubr/mailbug/

Comment 3

[Suresh Duddi (gone)]

Ugh. We are not going to fix this for mozilla 1.0 ?

Comment 4

[Jean-Francois Ducarroz]

No unless I run of crasher and hang or m,essage not displayed bugs before!

Comment 5

[Vadim Berezniker]

*** Bug 128186 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 164961 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 167497 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

Looks remarkably like bug 57800

Comment 9

[Jean-Francois Ducarroz]

The problem seems to occurs during the save operation! Looking at it...

Comment 10

[Jean-Francois Ducarroz]

forget my previous comment! the problem is that we don't correctly support
format=flowed when editing a draft/template or as new.

Comment 11

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v1

When we are extrating data for draft processing, we cannot use the plain text
flowed class decoder as it output HTML data. Therefore, we need to do the job
ourself.

Comment 12

[Jean-Francois Ducarroz]

Comment on attachment 106026 [details] [diff] [review]
Proposed fix, v1

Cavin, please review the patch. This change affect only draft/template message.
Thanks

Comment 13

[Cavin Song]

Comment on attachment 106026 [details] [diff] [review]
Proposed fix, v1

r=cavin.

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 106026 [details] [diff] [review]
Proposed fix, v1

assuming we have to check that line is not null, before de-refernce it.

also, since line is an arg, should we really be changing it?

how about this:

static int
MimeMessage_parse_line (char *aLine, ...)
{
char *line = aLine;

Comment 15

[Jean-Francois Ducarroz]

correct, the line has been already checked for null.
The line argument is not passed as reference therefore changing its value
locally wont affect the caller!

Comment 16

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v2

Seth convince me to do some coding style change...

Comment 17

[Jean-Francois Ducarroz]

Comment on attachment 106039 [details] [diff] [review]
Proposed fix, v2

carry over reviews

Comment 18

[Jean-Francois Ducarroz]

Fix checked in the trunk

Comment 19

[Jean-Francois Ducarroz]

*** Bug 57800 has been marked as a duplicate of this bug. ***