1129878 - enable atomic instructions on mips

Status: RESOLVED FIXED

(NSPR :: NSPR, enhancement, P1)

Description

[James Cowgill]

Attachment: 0001-nspr-enable-atomic-instructions-on-mips.patch

This patch enables the use of GCC atomic intrinsics on mips platforms. It's very similar to bug 626309 which enables this for ARM platforms.

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/108585f1f680

Comment 2

[Wan-Teh Chang]

Comment on attachment 8559738 [details] [diff] [review]
0001-nspr-enable-atomic-instructions-on-mips.patch

Review of attachment 8559738 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

Heiher: NSPR patches need to be pushed to the NSPR repository at
https://hg.mozilla.org/projects/nspr. The NSPR source tree is closed
until next Tuesday, so I can't check in this patch now.

Kai, could you please check in this patch when the NSPR tree reopens?
Thanks.

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/108585f1f680

Comment 4

[hev [:hev]]

(In reply to Wan-Teh Chang from comment #2)
> Comment on attachment 8559738 [details] [diff] [review]
> 0001-nspr-enable-atomic-instructions-on-mips.patch
> 
> Review of attachment 8559738 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=wtc.
> 
> Heiher: NSPR patches need to be pushed to the NSPR repository at
> https://hg.mozilla.org/projects/nspr. The NSPR source tree is closed
> until next Tuesday, so I can't check in this patch now.
Got it. thanks!

> 
> Kai, could you please check in this patch when the NSPR tree reopens?
> Thanks.

Comment 5

[Kai Engert (:KaiE:)]

I see you have checked in the patch directly to mozilla-central.

We don't do that, the Firefox tree consumes changes to the general NSPR and NSS libraries only as part of updates to newer snapshots.

I'm about to upgrade NSPR on mozilla-central to a release snapshot, which will override your checkin.

We can give you a NSPR beta snapshot tomorrow or wednesday, would that work for you?
Thanks

Comment 6

[Kai Engert (:KaiE:)]

Maybe I'll simply wait until tomorrow/wednesday with upgrading the NSPR snapshot in mozilla-central, so I don't have to effectively back it out.

Comment 7

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nspr/rev/7d5c4799ad36

Comment 8

[Wan-Teh Chang]

Kai: I don't think it is urgent for mozilla-central to receive the
patch for this bug. I would say if we push a new NSPR tag to m-c
within two weeks, that should be OK. Thanks for all your help!