Closed Bug 1129905 Opened 11 years ago Closed 11 years ago

Heartbeat page return 200 with really long delays where it should fail

Categories

(Hello (Loop) :: Server, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: alexis+bugs, Assigned: alexis+bugs)

References

Details

(Whiteboard: [loop-server 0.16.0])

Bug 1021726 added a heartbeat timeout, we changed it later to use a feature exposed by tokbox in their "opentok" SDK. Apparently, this decision was reverted [0] and the parameter removed. As such, our requests aren't timing out and we're unable to detect any really long time request using our heartbeat. [0] https://github.com/opentok/opentok-node/issues/51#issuecomment-52261490
For reference, see the previous discussions we had about that on https://github.com/opentok/opentok-node/pull/48 and Bug 1027877
Fix is at https://github.com/mozilla-services/loop-server/pull/299. Remy, can you have a look?
Flags: needinfo?(rhubscher)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [loop-server 0.16.0]
NI to self to verify
Flags: needinfo?(rpappalardo)
I tested this with a load of 240 users and: https://loop.stage.mozaws.net/__heartbeat__ returned the following: {"storage":true,"provider":false,"message":"TokBox Error: The request failed: Error: ETIMEDOUT"} marking this verified
Flags: needinfo?(rpappalardo)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.