1129914 - Make EditComments extension work on Bugzilla versions older than 5.0

Status: RESOLVED WONTFIX

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Mark Clements]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Build ID: 20140314220517

Steps to reproduce:

I installed the EditComments extension into my Bugzilla installation, which does not have memcached enabled/installed.


Actual results:

When I saved my changed I got the following error page:

Software error:

Can't locate object method "memcached" via package "Bugzilla" at ./extensions/EditComments/Extension.pm line 229.



Expected results:

The save should have worked even without memcached enabled.

The issue is that the following line is called unconditionally:

  Bugzilla->memcached->clear({ table => 'longdescs', id => $comment_id });

This should only be called if memcached is installed and enabled.

Bug 955962 deals with a similar issue in Bugzilla, and might provide some useful details about how this might be resolved.

Comment 1

[:glob ✱]

Bugzilla->memcached was added to bugzilla 5.0, where that call will work even if it isn't installed or enabled.

we could wrap that call in | if (Bugzilla->can('memached')) | but i'm not sure what other recent features that extension requires.

Comment 2

[David Lawrence [:dkl]]

Attachment: 1129914_1.patch

This allows the extension to work with 4.4, *but* 4.4 still needs the [% Hook.process('a_comment-end', 'bug/comments.html.tmpl') %] added to template/en/default/bug/comments.html.tmpl file which I doubt will be accepted into upstream 4.4. FWIW, the hook is in 5.0 already, but so is memcache support.

dkl

Comment 3

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #2)
> Created attachment 8559822 [details] [diff] [review]
> 1129914_1.patch
> 
> This allows the extension to work with 4.4, *but* 4.4 still needs the [%
> Hook.process('a_comment-end', 'bug/comments.html.tmpl') %] added to
> template/en/default/bug/comments.html.tmpl file which I doubt will be
> accepted into upstream 4.4. FWIW, the hook is in 5.0 already, but so is
> memcache support.

in light of this, i think this is a WONTFIX.

there's no point having non-working 4.4 support in the extension, and sites who are happy to carry a customised version can simply comment out the memcached line and insert the a_comment-end hook.

Comment 4

[Mark Clements]

In that case, it would be good if there were a 4.4 branch/tag in the Git repo, which provides a version of this (and presumably all of BMO) that works on 4.4, as currently there is no easy way to install on this version.  

https://github.com/mozilla/webtools-bmo-bugzilla


There are branches/tags for earlier revisions, but 4.4 seems to have been missed.

e.g. https://github.com/mozilla/webtools-bmo-bugzilla/tree/4.2

Comment 5

[:glob ✱]

(In reply to Mark Clements from comment #4)
> In that case, it would be good if there were a 4.4 branch/tag in the Git
> repo, which provides a version of this (and presumably all of BMO) that
> works on 4.4, as currently there is no easy way to install on this version.  

the problem is that EditComments does not work without modifications to bugzilla 4.4, so even if there was a 4.4 branch you wouldn't be able to install it into bugzilla 4.4.

Comment 6

[Mark Clements]

Oh.  Ok.

Did it work on 4.2, or is that branch misleading?

Comment 7

[:glob ✱]

(In reply to Mark Clements from comment #6)
> Did it work on 4.2, or is that branch misleading?

it's very misleading i'm sorry.  bmo runs a base of 4.2, but carries a lot of changes backported from newer releases -- all the way up to code which won't see the light of day until bugzilla 6.

Comment 8

[Mark Clements]

OK.  Thanks for the clarification.