1129921 - crash in java.lang.NullPointerException: Attempt to invoke virtual method ''boolean android.os.Handler.post(java.lang.Runnable)'' on a null object reference at org.webrtc.videoengine.VideoCaptureAndroid.stopCapture(VideoCaptureAndroid.java)

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

This bug was filed from the Socorro interface and is 
report bp-150b7001-e411-46c4-83eb-b4a112150205.
=============================================================

Tested with:
Device: Nexus 7 (Android 5.0.1);
Build: Firefox for Android 38.0a1 (2015-02-05);

Steps to reproduce:
1. Go to Menu -> Settings -> Privacy and from "Clear on exit" choose for example "Saved passwords"
2. Go to http://mozilla.github.com/webrtc-landing/gum_test.html
3. Tap "Audio & Video"
4. Choose "Share" from the doorhanger
5. Go to Menu -> Quit
=> Nightly crashes

Java Stack Trace:
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.os.Handler.post(java.lang.Runnable)' on a null object reference
	at org.webrtc.videoengine.VideoCaptureAndroid.stopCapture(VideoCaptureAndroid.java:347)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

This is probably because upstream assumes stopCaptures will only be called once, while we can call it from Suspend and then the native code calls it again for the application exiting.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Account for stopCapture possibly being called twice

Comment 3

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec32edc7fe6e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec32edc7fe6e

Comment 5

[Teodora Vermesan (:TeoVermesan)]

After quitting, Nightly does not crash, so verified as fixed using Nexus 7 (Android 5.0.1) on Firefox for Android 38.0a1 (2015-02-08).