[Header] We should not run twice when attaching + changing textContent

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::Components
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: julienw, Assigned: julienw)

Tracking

unspecified
2.2 S6 (20feb)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.2 fixed, b2g-master fixed)

Details

Attachments

(1 attachment)

54 bytes, text/x-github-pull-request
wilsonpage
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
When attaching a new header and then changing its content, we run runFontFit twice.

This happens especially in Settings because panels are appended dynamically and the l10n library translates them in a mutation handler.
(Assignee)

Comment 1

3 years ago
Created attachment 8559824 [details] [review]
github PR

hey Wilson,

This fixed the issue for me. We can see it quite easily when enabling the handy logs :)
Attachment #8559824 - Flags: review?(wilsonpage)
(Assignee)

Comment 2

3 years ago
Blocking Request: this is a performance improvement (I think we win ~10/15ms when this happens). This is not a launch-time performance improvement though.

I intend to uplift this as part of the other gaia-header enhancements and it would be really difficult to separate the various changes.
blocking-b2g: --- → 2.2?
(Assignee)

Comment 4

3 years ago
stamped 0.6.3
(Assignee)

Comment 5

3 years ago
master: https://github.com/mozilla-b2g/gaia/commit/8cade57c020f952bfe561c76f4afbcc51029e25a
v2.2: https://github.com/mozilla-b2g/gaia/commit/0b0e8e97e6b5bb34d58fcc5509daa7935a4f82b8
Status: NEW → RESOLVED
blocking-b2g: 2.2? → ---
Last Resolved: 3 years ago
status-b2g-v2.2: --- → fixed
status-b2g-master: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S6 (20feb)
You need to log in before you can comment on or make changes to this bug.