1129943 - [Header] We should not run twice when attaching + changing textContent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Julien Wajsberg [:julienw]]

When attaching a new header and then changing its content, we run runFontFit twice.

This happens especially in Settings because panels are appended dynamically and the l10n library translates them in a mutation handler.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: github PR

hey Wilson,

This fixed the issue for me. We can see it quite easily when enabling the handy logs :)

Comment 2

[Julien Wajsberg [:julienw]]

Blocking Request: this is a performance improvement (I think we win ~10/15ms when this happens). This is not a launch-time performance improvement though.

I intend to uplift this as part of the other gaia-header enhancements and it would be really difficult to separate the various changes.

Comment 3

[Wilson Page [:wilsonpage]]

Comment on attachment 8559824 [details] [review]
github PR

LANDED https://github.com/gaia-components/gaia-header/commit/984a0750555277d252286806a162b6736fdb0251

Comment 4

[Julien Wajsberg [:julienw]]

stamped 0.6.3

Comment 5

[Julien Wajsberg [:julienw]]

master: https://github.com/mozilla-b2g/gaia/commit/8cade57c020f952bfe561c76f4afbcc51029e25a
v2.2: https://github.com/mozilla-b2g/gaia/commit/0b0e8e97e6b5bb34d58fcc5509daa7935a4f82b8