When attaching a new header and then changing its content, we run runFontFit twice. This happens especially in Settings because panels are appended dynamically and the l10n library translates them in a mutation handler.
Created attachment 8559824 [details] [review] github PR hey Wilson, This fixed the issue for me. We can see it quite easily when enabling the handy logs :)
Attachment #8559824 - Flags: review?(wilsonpage)
Blocking Request: this is a performance improvement (I think we win ~10/15ms when this happens). This is not a launch-time performance improvement though. I intend to uplift this as part of the other gaia-header enhancements and it would be really difficult to separate the various changes.
blocking-b2g: --- → 2.2?
Comment on attachment 8559824 [details] [review] github PR LANDED https://github.com/gaia-components/gaia-header/commit/984a0750555277d252286806a162b6736fdb0251
Attachment #8559824 - Flags: review?(wilsonpage) → review+
master: https://github.com/mozilla-b2g/gaia/commit/8cade57c020f952bfe561c76f4afbcc51029e25a v2.2: https://github.com/mozilla-b2g/gaia/commit/0b0e8e97e6b5bb34d58fcc5509daa7935a4f82b8
Status: NEW → RESOLVED
blocking-b2g: 2.2? → ---
Last Resolved: 3 years ago
status-b2g-v2.2: --- → fixed
status-b2g-master: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.