Closed
Bug 1129955
Opened 10 years ago
Closed 10 years ago
[AccessFu] Expose name changed event for currently focused accessible.
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: yzen, Assigned: yzen)
References
Details
Attachments
(1 file)
|
12.42 KB,
patch
|
eeejay
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
AccessFu should output the name change accessible event for the current virtual cursor position accessibles.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8559830 -
Flags: review?(eitan)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8559830 [details] [diff] [review]
1129955 patch v1
Review of attachment 8559830 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
::: accessible/tests/mochitest/jsat/doc_content_integration.html
@@ +87,5 @@
> </div>
> <div id="appframe"></div>
> </div>
> <button id="home">Home</button>
> + <button id="toggle" aria-label="toggle"></button>
The name 'toggle'/'toggled' is a bit misleading. Maybe something more benign like fruit? This could be confusing with aria-checked/aria-pressed, and roles in general.
Attachment #8559830 -
Flags: review?(eitan) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8559830 [details] [diff] [review]
1129955 patch v1
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment] This a screen reader fix that addressed bug 1069476
Bug caused by (feature/regressing bug #): improvement, not a bug
User impact if declined: The screen reader user will not know if description/text changes for the elements (such as buttons) that the screen reader is positioned on.
Testing completed: Added a11y mochitests + manual
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: None
Attachment #8559830 -
Flags: approval-mozilla-b2g37?
|
||
Updated•10 years ago
|
Attachment #8559830 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
|
||
Comment 6•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
status-firefox36:
--- → wontfix
status-firefox37:
--- → wontfix
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•