If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

Firefox OS
Gaia::L10n
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
it will be convenient to import and cache l20n via CDN, which is free and accessible for everyone

https://cdnjs.com/

Need a Pull request to https://github.com/gasolin/cdnjs
(Assignee)

Updated

3 years ago
Assignee: nobody → gasolin
(Assignee)

Comment 1

3 years ago
Created attachment 8559869 [details] [review]
pull request redirect to github

It's a PR to cdnjs, with l20n.js/l20n.min.js from l20n/build.git, and the new package.json with some extra settings.

cdnjs test passed.
Attachment #8559869 - Flags: review?(stas)
Thanks for suggesting this, Fred!  Two questions:

 - will we need to file a new pull request to cdnjs everytime we make a release of L20n?  Is there a way for them to pull from npm/bower instead?

 - I also wanted to clarify that l20n 1.x is not what we're shipping in Firefox OS so it might be misleading to call this package "A localization library from Firefox OS".  Firefox OS uses the 2.x line of development which is the master branch of the l20n/l20n.js repo and has a different API.  The plan is to converge in version 3.x in the future (this year, I hope).
(Assignee)

Comment 3

3 years ago
1. I believe it will automatically update by fetching github release. (with autoupdate statement in package.json) so there no extra work need to be done from our side.

2. I totally understand the versions difference but the origin statement `for Firefox OS` is also miss leading and prevent developer to try the library if they have no plan for FxOS app yet. 

Since the PR has been merged to cdnjs and available on https://cdnjs.com/libraries/l20n 
I tend to add another patch and change the statement as `A client side localization library from Mozilla`. How do you think?
Comment on attachment 8559869 [details] [review]
pull request redirect to github

Thanks for answering my questions.  If you have cycles, please change the description in a separate pull request, yes.
Attachment #8559869 - Flags: review?(stas) → review+
(Assignee)

Comment 5

3 years ago
Here's the PR that change the statement https://github.com/cdnjs/cdnjs/pull/4356
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Thanks, Fred!
You need to log in before you can comment on or make changes to this bug.