Closed Bug 1130094 Opened 7 years ago Closed 7 years ago

Hook up share button for reader mode toolbar

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

The share button needs to do something! I believe we want it to open the same popup that the share toolbar button opens.

Jared, do you have any ideas about how I could make this happen? This toolbar is in the about:reader HTML, but I imagine this popup is created with XUL.

I imagine we'd want to do this from ReaderParent.jsm, since AboutReader.jsm is shared with Fennec and is also designed to run in the content process. However, I worry that the popup positioning might be tricky if we're trying to anchor it to some HTML element in the page.
Flags: needinfo?(jaws)
Actually, mmaslaney removed the share button from the reader mode toolbar in the updated mock-ups. So that takes care of this problem for us!
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jaws)
Resolution: --- → INVALID
See Also: → 1188380
You need to log in before you can comment on or make changes to this bug.