There should be no separators between the last pinned tab and the overflow arrow

NEW
Unassigned

Status

()

Firefox
Theme
4 years ago
3 years ago

People

(Reporter: bgrins, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
Created attachment 8560077 [details]
tab-overflow-separator.png

See screenshot and https://bugzilla.mozilla.org/show_bug.cgi?id=1093820#c49.
(Reporter)

Comment 1

4 years ago
In the default theme when you have a pinned tab with overflowing tabs, there is a separator between the overflow arrow and the first unpinned tab (see Attachment 8560077 [details])

The suggestion is instead to have the separator between the last pinned tab and the arrow.

Stephen, I haven't seen any mockups for this particular configuration (with a pinned tab and overflowing tabs).  Do you agree with the suggestion to move the separator for dev edition, or should we leave it matching the default theme?
Flags: needinfo?(shorlander)
(Reporter)

Comment 2

4 years ago
Most likely we should make this decision for both the default and dev edition themes at the same time.  I don't think dev edition makes it particularly worse.
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Updated

4 years ago
Summary: There should be a separator between the last pinned tab and overflow arrow in the DevEdition theme → There should be a separator between the last pinned tab and overflow arrow
There should not be a tab separator on either side of the arrow. Just between tabs.
Flags: needinfo?(shorlander)
(Reporter)

Comment 4

4 years ago
Created attachment 8560714 [details] [diff] [review]
first-tab-separator-hidden.patch

This is just a rough idea of how it could work.  I'll attach a screenshot
(Reporter)

Comment 5

4 years ago
Created attachment 8560719 [details]
tab-splitter-states.png

This is what it looks like in various states.  There is quite a bit of blank space between the arrow and the first tab, but what do you think?
Attachment #8560719 - Flags: ui-review?(shorlander)
Looks good to me. I think the spacing between the arrow and the first tab is fine. Well, it would be nice if it could tighter, but I think the entire button area has to clear the end of the curve or the overlap would be awkward. Would have to change the appearance otherwise.
Attachment #8560719 - Flags: ui-review?(shorlander) → ui-review+
(Reporter)

Comment 7

4 years ago
Updating title to match UI feedback
Summary: There should be a separator between the last pinned tab and overflow arrow → There should be no separators between the last pinned tab and the overflow arrow

Comment 8

3 years ago
My opinion on this: Users would like rather to see separators both between pinned tab and overflow scrollbutton AND before 1st tab in overflow box. (I wonder who decides to make user restore those not-too-awful things with extension/styles)

Now what for the realization:
Your patch won't work if user moves 1st tab in another tab group. So currently it's half-broken solution. My suggestion is (requires more work) to always set "[first-visible-tab]" attr to the 1st visible not-pinned tab, since for pinned tabs it's equal to [pinned][first-tab]. Or to set another attr to the 1st visible not-pinned tab (that'd also help FXChrome theme)

Comment 9

3 years ago
(In reply to arni2033 from comment #8)
> Your patch won't work if user moves 1st tab in another tab group
* if user moves 1st *not-pinned* tab in another tab group.
I admit that current styling already has long-standing issues with tab groups (I can send bug numbers)
You need to log in before you can comment on or make changes to this bug.