1130159 - Disable installing apns-conf.xml by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Michael Wu [:mwu]]

I don't think we use apns-conf.xml in our radio code, and many manifests don't have the goldfish repo, so let's remove this.

Comment 1

[Michael Wu [:mwu]]

Attachment: Don't install the goldfish apns-conf.xml by default

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8560090 [details] [review]
Don't install the goldfish apns-conf.xml by default

Correct, our ril code doesn't use this. Thank you.

Comment 3

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/platform_build/commit/e9c68a8f768d569622fe09d05a5be59d0bd86baa

Comment 4

[u535950]

Attachment: Cherry-pick "Don't install the goldfish apns-conf.xml by default" patch for JB

Hello,

I know that JB is no longer maintained, but is it possible to make an exception ? It's necessary for building a full JB image for Open C.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to micgeri from comment #4)
> Created attachment 8715289 [details] [review]
> Cherry-pick "Don't install the goldfish apns-conf.xml by default" patch for
> JB
> 
> Hello,
> 
> I know that JB is no longer maintained, but is it possible to make an
> exception ? It's necessary for building a full JB image for Open C.

Hi Sorry for the delay. It was Chinese new year holiday the last week.

I think cherry picking this for JB makes no harm so it's fine to me. But I'd like to hear Michael's opinion. Thanks!

Comment 6

[u535950]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #5)
> (In reply to micgeri from comment #4)
> > Created attachment 8715289 [details] [review]
> > Cherry-pick "Don't install the goldfish apns-conf.xml by default" patch for
> > JB
> > 
> > Hello,
> > 
> > I know that JB is no longer maintained, but is it possible to make an
> > exception ? It's necessary for building a full JB image for Open C.
> 
> Hi Sorry for the delay. It was Chinese new year holiday the last week.
> 
> I think cherry picking this for JB makes no harm so it's fine to me. But I'd
> like to hear Michael's opinion. Thanks!

Hello,

Ok, no problem

Comment 7

[Michael Wu [:mwu]]

merged https://github.com/mozilla-b2g/platform_build/commit/8df1b0580ade1786bc1bf05a6abc06bcd62c2d6b

Comment 8

[u535950]

Thanks