1130193 - turn on config enablePruning in production

Status: RESOLVED FIXED

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[John Morrison [:jrgm]]

This never got enabled and fell off the radar. My fault. We need to turn on enablePruning in production (and re-estimate if we can just turn it on, or if we need to do little trimming if the tables are too large (shouldn't be)).

Comment 1

[Andrew Chilton [:chilts]]

Isn't this just a config option in the DB Server config to turn it on? ie. that we have control over.

Comment 2

[Ryan Kelly [:rfkelly]]

> This never got enabled and fell off the radar

:jrgm, did this continue its fall off the radar, or is it running in prod these days?

Comment 3

[Ryan Kelly [:rfkelly]]

:jrgm, did we ever get around to doing this in production?

Comment 4

[Vlad Filippov (:vladikoff)]

Talked to :jrgm about this and we wanted to confirm that the `pruneBefore` value is correct here: https://github.com/mozilla/fxa-auth-db-mysql/blob/22e27d16d635927d2facfe8382030ec10447e600/lib/db/schema/patch-003-004.sql#L3

the `pruneBefore` value is also used here https://github.com/mozilla/fxa-auth-db-mysql/blob/a902f48a57cebbd17350818d90c23246099de9d2/lib/db/mysql.js#L948 as a `TOKEN OLDER THAN` 30 mins?

Is that correct?

Comment 5

[Ryan Kelly [:rfkelly]]

:vladikoff you're right, there's something very fishy about use of `pruneBefore`.  I think it will work as long a `options.pruneEvery` is greater than or equal to the maximum lifetime of any of these tokens, but we should probably re-work things a little here to make it more obvious that this is the case.  Maybe we can rename it to "maxTokenLifetime" or something.

Comment 6

[Vlad Filippov (:vladikoff)]

ni'd myself so I don't forget...

Comment 7

[Ryan Kelly [:rfkelly]]

I added some notes on code cleanups in https://github.com/mozilla/fxa-auth-db-mysql/issues/201

Comment 8

[Vlad Filippov (:vladikoff)]

This is on track to be turned on in Train-81, a note made in the deploy doc for this...