1130285 - [l10n] Numbers are not formatted correctly for dsb, hsb

Status: RESOLVED FIXED

(www.mozilla.org :: L10N, defect)

Description

[Francesco Lodolo [:flod]]

https://www.mozilla.org/hsb/
https://www.mozilla.org/dsb/

Numbers are formatted the "English way", with commas as thousands separator.

I assume this is a limitation in babel?
https://github.com/mozilla/bedrock/blob/master/lib/l10n_utils/helpers.py#L9

Comment 1

[Michael Wolf]

Hello Francesco, thank you for filing the bug.

Comment 2

[Paul [:pmac] McLanahan]

Looks like you're right. It's possible that's configurable, or we may need to update babel. I'll check it out. Thanks.

Comment 3

[Paul [:pmac] McLanahan]

Looks like even latest version of Babel doesn't know anything about hsb or dsb. Babel [0] gets its data from the CLDR (Unicode Common Locale Data Repository) [1]. If we know that hsb and/or dsb follow the number formatting rules of another locale we do have, we should be able to map it for bedrock and make it work.

[0] http://babel.pocoo.org/docs/
[1] http://cldr.unicode.org/

Comment 4

[Francesco Lodolo [:flod]]

CLDR does have dsb/hsb, but it seems to be introduced in version 26.

Available
http://www.unicode.org/cldr/charts/26/by_type/numbers.number_formatting_patterns.html#53687a25c19b6481

Missing
http://www.unicode.org/cldr/charts/25/by_type/numbers.number_formatting_patterns.html#53687a25c19b6481

I think German should be the natural fallback for dsb/hsb. Michael, is that correct?

Comment 5

[Michael Wolf]

Yes, you can use German as fallback here.

Comment 6

[Paul [:pmac] McLanahan]

Attachment: Link to Github pull-request: https://github.com/mozilla/bedrock/pull/2711

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Babel seems to be using cldr 23.1, would it make sense to maybe make an upstream patch to have them use 26?

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/64c4f177580495fc1704e78e7f41fa2833ff6613
Fix bug 1130285: Treat hsb/dsb locales as de for number formatting.

https://github.com/mozilla/bedrock/commit/01db764178854a1e410d6c6bb55ad1b7002fab70
Merge pull request #2711 from pmclanahan/fix-dsb-hsb-number-formatting-1130285

Fix bug 1130285: Treat hsb/dsb locales as de for number formatting.

Comment 9

[Paul [:pmac] McLanahan]

(In reply to Pascal Chevrel:pascalc from comment #7)
> Babel seems to be using cldr 23.1, would it make sense to maybe make an
> upstream patch to have them use 26?

That would be a nice thing to do. We're fairly behind in our version of Babel anyway. There appear to be 2 new versions of Bable set to be released (1.4 and 2.0) [0]. Maybe one or both of them will have that lib updated.

[0] http://babel.pocoo.org/docs/changelog/

Comment 10

[Michael Wolf]

It works for www-dev.allizom.org/hsb resp. www-dev.allizom.org/dsb now but not for www.mozill.org/hsb bzw. www.mozilla.org/dsb

Comment 11

[Francesco Lodolo [:flod]]

That's expected. Changes are pushed to production periodically, but not on Fridays. It should be available next week on mozilla.org

Comment 12

[Michael Wolf]

Thank you, Francesco, for the information.

Comment 13

[Michael Wolf]

Thank you, it works for mozilla.org as well.