Closed Bug 1130290 Opened 7 years ago Closed 7 years ago

Remove PeerConnectionImpl::CreateFakeMediaStream

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove PeerConnectionImpl::CreateFakeMediaStream
8.02 KB, patch
jesup
: review+
Details | Diff | Splinter Review 
PeerConnectionImpl::CreateFakeMediaStream and its friend classes Fake_AudioGenerator and Fake_VideoGenerator appear to be dead code. Let's remove them.
Blocks: 1129263
Assignee: nobody → pehrsons
Status: NEW → ASSIGNED
Forgot to add the removal of MEDIA_STREAM_MUTE to the changeset.
Attachment #8560311 - Attachment is obsolete: true
Comment on attachment 8560316 [details] [diff] [review]
Remove PeerConnectionImpl::CreateFakeMediaStream

Try agrees that it was dead code: https://treeherder.mozilla.org/#/jobs?repo=try&revision=456e0ba0ea63
Attachment #8560316 - Flags: review?(rjesup)
Attachment #8560316 - Flags: review?(rjesup) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5a483447631e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.