Closed
Bug 1130290
Opened 6 years ago
Closed 6 years ago
Remove PeerConnectionImpl::CreateFakeMediaStream
Categories
(Core :: WebRTC: Audio/Video, defect)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(1 file, 1 obsolete file)
8.02 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
PeerConnectionImpl::CreateFakeMediaStream and its friend classes Fake_AudioGenerator and Fake_VideoGenerator appear to be dead code. Let's remove them.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → pehrsons
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Forgot to add the removal of MEDIA_STREAM_MUTE to the changeset.
Attachment #8560311 -
Attachment is obsolete: true
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8560316 [details] [diff] [review] Remove PeerConnectionImpl::CreateFakeMediaStream Try agrees that it was dead code: https://treeherder.mozilla.org/#/jobs?repo=try&revision=456e0ba0ea63
Attachment #8560316 -
Flags: review?(rjesup)
Updated•6 years ago
|
Attachment #8560316 -
Flags: review?(rjesup) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a483447631e
Keywords: checkin-needed
Comment 5•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5a483447631e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•