1130307 - [RTL][Settings]The menu button is mirrored in Downloads.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Sue]

Attachment: menu.png

[1.Description]:
[RTL][Settings]When you go to Settings -> Downloads, the menu button is mirrored.
See attachment:menu.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic.
1. Launch Settings app.
2. Select Downloads and observe the menu button at top right.

[3.Expected Result]: 
2. The menu button should not be mirrored.

[4.Actual Result]: 
2. The menu button is mirrored.

[5.Reproduction build]: 
Flame 2.2 build:
Build ID               20150205002503
Gaia Revision          c2047a46e29696238e9b4c9caaba47736421449a
Gaia Date              2015-02-04 20:34:04
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/adfba0a07e9b
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150205.045043
Firmware Date          Thu Feb  5 04:50:54 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Dylan Oliver [:doliver]]

triage: P3, valid but low impact, would take a fix for 2.2

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] EragonJ:bug-1130307 to mozilla-b2g:master

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8561165 [details] [review]
[PullReq] EragonJ:bug-1130307 to mozilla-b2g:master

Hi Arthur, can you help me review this simple patch ? Thanks !

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8561165 [details] [review]
[PullReq] EragonJ:bug-1130307 to mozilla-b2g:master

r=me, thanks.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur ! 

This patch was merged into Gaia/master: https://github.com/mozilla-b2g/gaia/commit/a01f1b61ad89d76c4c0f8cca688116c3baed22a9

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8561165 [details] [review]
[PullReq] EragonJ:bug-1130307 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: the menu icon in download manager got mirrored in RTL languages.
[Testing completed]: no, only one-line CSS change
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5ddfee8a895b7336cf26f886de639ce8efcdf8ac

Comment 8

[Coler]

This issue has been verified successfully on Flame 3.0.

Flame 3.0 build:

Build ID               20150210010523
Gaia Revision          0cf517083f7eb5fc269e1236edba50534f65e3cd
Gaia Date              2015-02-09 18:21:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2cb22c058add
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150210.050217
Firmware Date          Tue Feb 10 05:02:28 EST 2015
Bootloader             L1TC000118D0

Comment 9

[Sue]

Attachment: 2015-02-12-09-42-17.png

This issue has been verified successfully on Flame v2.2
STR:
Prerequisite: Set system language as Arabic.
1. Launch Settings app.
2. Select Downloads and observe the menu button at top right.
**The menu button is not mirrored.
See attachment:2015-02-12-09-42-17.png
Rate:0/5

Flame 2.2 build:
Build ID               20150211002505
Gaia Revision          943be6fd146017dcd9d4c9d1027be1e43bad13eb
Gaia Date              2015-02-11 08:01:09
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e614443583e7
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150211.040242
Firmware Date          Wed Feb 11 04:02:53 EST 2015
Bootloader             L1TC000118D0

Comment 10

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15782/