113031 - Sidebar does not redraw, does not collapse

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[Anders Korsvall]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/20011130
BuildID:    2001113003

Reproducible: Always
Steps to Reproduce:
1. Collapse the sidebar. 
2. Hide the sidebar from the "View" menu.
3. Show the sidebar again.

Actual Results:  The sidebar does not redraw correctly and the collapse button
does not work. If you resize the sidebar it starts to work again. 

Expected Results:  The sidebar should redraw as intended and the collapse button
should work.

Comment 1

[Alon Altman]

Confirmed. Did not find dupe. I think this blocks rfe bug 70126

Comment 2

[Martin Poirier]

See news://news.mozilla.org:119/[e-mail] for newsgroup
discussion about this problem. The problem I see is a bit worst though. I'm on
Win98SE. I usually have my sidebar hidden with F9, but I stumbled on this
newsgroup post and hit F9 to see the problem. The sidebar appeared collapsed,
and the grippy doesn't work for expanding it. F9 doesn'T hide the collapsed
sidebar either. I'm stuck with a collapsed sidebar in my view, and I can't hide
it, expand it, nor resize it. When I try to resize, It doesn't work and the
mouse cursor get stuck with the horizontal arrow appearance, mozilla becoming
unusable, as I can't click on anything.

Comment 3

[Colin Phillips]

Information from bug 113085: (marking as dupe)

When toggling the sidebar open/closed using either the menu item in View, or F9,
the "Tabs" button stops working after it is closed and then reopened (and
everytime you toggle it thereafter within that window).

Note, the button works if
- a navigator window is launched and the sidebar is open already (but breaks
once you toggle it)
- a navigator window is launched and the sidebar was not open, but is toggled
open.  (It will break if you toggle it closed and then reopen it)

Comment 4

[Colin Phillips]

*** Bug 113085 has been marked as a duplicate of this bug. ***

Comment 5

[Samir Gehani]

Attachment: Remove the 'hidden' attribute on the boxes conatining the sidebar.

The sidebarOverlay.js revision 1.86 change made it so that the boxes containing
the sidebar were collapsed rather than hidden to support persistence.  It
failed to take into account old profiles that may already have 'closed'
sidebars.  So we must remove the 'hidden' attribute from the boxes containing
the sidebar when we attempt to reopen it even though the current sidebar code
never sets the hidden attribute.  This is purely a backward-compatibility patch
but one necessary cause it is ``easy'' for older profiles to run into.

Comment 6

[Samir Gehani]

morse, please r.
alecf, please sr.  

Comment 7

[Stephen P. Morse]

Comment on attachment 60198 [details] [diff] [review]
Remove the 'hidden' attribute on the boxes conatining the sidebar.

r=morse

Comment 8

[Alec Flett]

Comment on attachment 60198 [details] [diff] [review]
Remove the 'hidden' attribute on the boxes conatining the sidebar.

sr=alecf

Comment 9

[Samir Gehani]

Checked in.

Comment 10

[sujay]

REOPEN...I still see this broken in 12/20 windows commercial trunk..

easy to reproduce...follow steps in original report...

Comment 11

[Samir Gehani]

This fix unmasked another defect: bug 110694 (which has a fix and is awaiting
super-review).  The collapse button works now.  

Comment 12

[sujay]

seems to be working now...Anders, reopen if you still think its not fixed...

I tried your original steps....seems fine.

Comment 13

[Anders Korsvall]

It works here too. Verified.