Closed Bug 1130311 Opened 6 years ago Closed 6 years ago

Disable dormant heuristic on Windows on beta

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox36 --- fixed
firefox37 --- unaffected
firefox38 --- unaffected

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since we're not shipping MSE in Fx36, and we have Bug 1128357 in beta, I think we should disable dormant heuristic in Fx36.
Approval Request Comment
[Feature/regressing bug #]: bug 1123535, shutting down idle decoders
[User impact if declined]: Sometimes we'll not display the first or last frame of a video if the user loads the video in a background tab. This affects both MSE and non-MSE video.
[Describe test coverage new/current, TreeHerder]: I saw RyanVM complaining about media orange earlier today, so maybe this was it...
[Risks and why]: This patch turns off a feature, so we'll revert to the old behaviour we had in 36.
[String/UUID change made/needed]: None.
Attachment #8560355 - Flags: review?(giles)
Attachment #8560355 - Flags: approval-mozilla-beta?
Comment on attachment 8560355 [details] [diff] [review]
Patch: Disable MP4Reader dormant heuristic

I agree this seems safer. r=me.
Attachment #8560355 - Flags: review?(giles) → review+
Attachment #8560355 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/8174cebcfbbd
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.