1130388 - Edit a review link does not work correctly for admins on mobile for other's reviews

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Valentina Virlics [:vvalentina], VPN QA]

Steps to reproduce:
1. Sign in to MP-dev on your Inari device (FF OS 1.4) with an admin account
2. Load details page for any app with reviews
3. Load Reviews page and click “Edit” link for any review
 
Expected results:
The “Edit Review” popup window is displayed, containing the message that the user picked to edit.

Actual results:
The “Leave a review” popup window is displayed.

Notes/Issues:
Verified on FF OS 1.4 (Inari). Issue is also reproducing on FF OS 2.0 (Flame) 
Ashes ID: 8d3aa

Comment 1

[Kevin Ngo [:ngoke]]

Tried on my Flame in the browser. If it's on the app, assets might be outdated?

Comment 2

[Valentina Virlics [:vvalentina], VPN QA]

(In reply to Kevin Ngo [:ngoke] from comment #1)
> Tried on my Flame in the browser. If it's on the app, assets might be
> outdated?

The app it's up to date. I think you picked a particular case, when an app was previously reviewed by you and then you tried to edit another review. In this case, the "Edit review" pop up window is displayed but your review is opened to be edited, and not the one you've picked to edit.(Ashes ID: 62a4a)
(i also think this is a logged issue)

The logged issue, at comment #0, is still reproducing if you want to edit any comment, from any app.
Ashes ID: 74845

Comment 3

[Kevin Ngo [:ngoke]]

Will not be on stage this week:

https://github.com/mozilla/fireplace/commit/d4b639413dad5ffd698f2839101979bc722590d9

Comment 4

[Valentina Virlics [:vvalentina], VPN QA]

Verified as fixed on MP-dev on FF OS 1.4(Inari - Ashes ID: a2fd8) and FF OS 2.0 (Flame). 
Closing bug.